Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve access service #4689

Merged
merged 17 commits into from
Sep 19, 2023

Fix test

45c285e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

chore: improve access service #4689

Fix test
45c285e
Select commit
Loading
Failed to load commit list.
GitHub Actions / Unit Tests failed Sep 13, 2023 in 0s

Unit Tests ❌

Tests failed

❌ jest-junit.xml

2275 tests were completed in 251s with 2272 passed, 1 failed and 2 skipped.

Test suite Passed Failed Skipped Time
src/lib/addons/addon.test.ts 4✅ 7s
src/lib/addons/datadog.test.ts 6✅ 1s
src/lib/addons/feature-event-formatter-md.test.ts 26✅ 2s
src/lib/addons/slack-app.test.ts 6✅ 2s
src/lib/addons/slack.test.ts 8✅ 1s
src/lib/addons/teams.test.ts 5✅ 2s
src/lib/addons/webhook.test.ts 4✅ 2s
src/lib/app.test.ts 3✅ 4s
src/lib/create-config.test.ts 33✅ 1s
src/lib/db/event-store.test.ts 2✅ 1s
src/lib/db/feature-strategy-store.test.ts 4✅ 4s
src/lib/db/segment-store.test.ts 1✅ 4s
src/lib/domain/project-health/project-health.test.ts 9✅ 1s
src/lib/error/unleash-error.test.ts 26✅ 623ms
src/lib/features/export-import-toggles/export-import-api-usage.test.ts 1✅ 6s
src/lib/features/export-import-toggles/export-import-permissions.e2e.test.ts 1✅ 7s
src/lib/features/export-import-toggles/export-import.e2e.test.ts 17✅ 13s
src/lib/features/export-import-toggles/import-context-validation.test.ts 3✅ 203ms
src/lib/features/feature-naming-pattern/feature-naming-validation.test.ts 7✅ 379ms
src/lib/features/feature-toggle/time-to-production/time-to-production.test.ts 1✅ 645ms
src/lib/features/playground/advanced-playground.test.ts 3✅ 6s
src/lib/features/playground/generateObjectCombinations.test.ts 2✅ 205ms
src/lib/features/playground/offline-unleash-client.test.ts 10✅ 708ms
src/lib/features/playground/playground-view-model.test.ts 2✅ 346ms
src/lib/features/playground/playground.test.ts 7✅ 16s
src/lib/features/playground/validateQueryComplexity.test.ts 2✅ 288ms
src/lib/logger.test.ts 2✅ 330ms
src/lib/metrics.test.ts 9✅ 2s
src/lib/middleware/api-token-middleware.test.ts 8✅ 1s
src/lib/middleware/content_type_checker.test.ts 5✅ 1s
src/lib/middleware/cors-origin-middleware.test.ts 5✅ 3s
src/lib/middleware/no-authentication.test.ts 1✅ 982ms
src/lib/middleware/oss-authentication.test.ts 2✅ 3s
src/lib/middleware/pat-middleware.test.ts 5✅ 407ms
src/lib/middleware/rbac-middleware.test.ts 13✅ 2s
src/lib/openapi/index.test.ts 6✅ 1s
src/lib/openapi/meta-schema-rules.test.ts 663✅ 2s
src/lib/openapi/spec/addon-schema.test.ts 1✅ 2s
src/lib/openapi/spec/addons-schema.test.ts 1✅ 2s
src/lib/openapi/spec/admin-features-query-schema.test.ts 3✅ 2s
src/lib/openapi/spec/api-token-schema.test.ts 2✅ 2s
src/lib/openapi/spec/change-password-schema.test.ts 2✅ 2s
src/lib/openapi/spec/client-application-schema.test.ts 5✅ 1s
src/lib/openapi/spec/client-features-query-schema.test.ts 2✅ 2s
src/lib/openapi/spec/client-features-schema.test.ts 5✅ 2s
src/lib/openapi/spec/client-metrics-schema.test.ts 3✅ 2s
src/lib/openapi/spec/constraint-schema.test.ts 3✅ 2s
src/lib/openapi/spec/context-field-schema.test.ts 2✅ 2s
src/lib/openapi/spec/email-schema.test.ts 1✅ 2s
src/lib/openapi/spec/event-schema.test.ts 1✅ 4s
src/lib/openapi/spec/events-schema.test.ts 2✅ 2s
src/lib/openapi/spec/export-query-schema.test.ts 1✅ 3s
src/lib/openapi/spec/export-result-schema.test.ts 1✅ 1s
src/lib/openapi/spec/feature-environment-schema.test.ts 2✅ 2s
src/lib/openapi/spec/feature-events-schema.test.ts 2✅ 2s
src/lib/openapi/spec/feature-metrics-schema.test.ts 1✅ 2s
src/lib/openapi/spec/feature-schema.test.ts 4✅ 1s
src/lib/openapi/spec/feature-type-schema.test.ts 2✅ 2s
src/lib/openapi/spec/feature-usage-schema.test.ts 1✅ 2s
src/lib/openapi/spec/features-schema.test.ts 1✅ 2s
src/lib/openapi/spec/groups-schema.test.ts 1✅ 2s
src/lib/openapi/spec/instance-admin-stats-schema.test.ts 1✅ 2s
src/lib/openapi/spec/me-schema.test.ts 4✅ 2s
src/lib/openapi/spec/playground-feature-schema.test.ts 3✅ 4s
src/lib/openapi/spec/playground-request-schema.test.ts 4✅ 3s
src/lib/openapi/spec/playground-response-schema.test.ts 6✅ 19s
src/lib/openapi/spec/profile-schema.test.ts 1✅ 2s
src/lib/openapi/spec/project-schema.test.ts 2✅ 2s
src/lib/openapi/spec/public-signup-schema.test.ts 1✅ 2s
src/lib/openapi/spec/role-schema.test.ts 1✅ 2s
src/lib/openapi/spec/sdk-context-schema.test.ts 3✅ 3s
src/lib/openapi/spec/set-strategy-sort-order-schema.test.ts 5✅ 2s
src/lib/openapi/spec/sort-order-schema.test.ts 2✅ 2s
src/lib/openapi/spec/strategy-schema.test.ts 1✅ 2s
src/lib/openapi/spec/tag-types-schema.test.ts 1✅ 5s
src/lib/openapi/spec/tags-bulk-add-schema.test.ts 1✅ 2s
src/lib/openapi/spec/token-user-schema.test.ts 1✅ 2s
src/lib/openapi/spec/ui-config-schema.test.ts 1✅ 2s
src/lib/openapi/spec/update-tags-schema.test.ts 1✅ 2s
src/lib/openapi/spec/user-schema.test.ts 1✅ 2s
src/lib/openapi/spec/users-groups-base-schema.test.ts 1✅ 2s
src/lib/openapi/spec/users-schema.test.ts 1✅ 6s
src/lib/openapi/spec/users-search-schema.test.ts 1✅ 1s
src/lib/openapi/spec/validate-password-schema.test.ts 2✅ 2s
src/lib/openapi/util/create-request-schema.test.ts 1✅ 260ms
src/lib/openapi/util/create-response-schema.test.ts 2✅ 463ms
src/lib/openapi/util/openapi-tags.test.ts 2✅ 244ms
src/lib/openapi/validate.test.ts 1✅ 2s
src/lib/proxy/create-context.test.ts 8✅ 1⚪ 211ms
src/lib/routes/admin-api/config.test.ts 1✅ 4s
src/lib/routes/admin-api/context.test.ts 12✅ 6s
src/lib/routes/admin-api/email.test.ts 3✅ 3s
src/lib/routes/admin-api/events.test.ts 5✅ 5s
src/lib/routes/admin-api/metrics.test.ts 9✅ 5s
src/lib/routes/admin-api/public-signup.test.ts 6✅ 5s
src/lib/routes/admin-api/strategy.test.ts 16✅ 6s
src/lib/routes/admin-api/tag.test.ts 7✅ 4s
src/lib/routes/admin-api/user/user.test.ts 6✅ 8s
src/lib/routes/auth/simple-password-provider.test.ts 3✅ 3s
src/lib/routes/backstage.test.ts 1✅ 6s
src/lib/routes/client-api/feature.test.ts 6✅ 4s
src/lib/routes/client-api/metrics.test.ts 11✅ 6s
src/lib/routes/client-api/register.test.ts 6✅ 5s
src/lib/routes/health-check.test.ts 2✅ 5s
src/lib/routes/logout.test.ts 11✅ 2s
src/lib/routes/public-invite.test.ts 7✅ 5s
src/lib/schema/api-token-schema.test.ts 6✅ 467ms
src/lib/schema/constraint-value-types.test.ts 9✅ 686ms
src/lib/schema/feature-schema.test.ts 18✅ 528ms
src/lib/schema/role-schema.test.ts 7✅ 382ms
src/lib/server-impl.test.ts 5✅ 3s
src/lib/services/access-service.test.ts 9✅ 3s
src/lib/services/addon-service.test.ts 21✅ 3s
src/lib/services/api-token-service.test.ts 3✅ 1s
src/lib/services/client-metrics/instance-service.test.ts 4✅ 1s
src/lib/services/client-metrics/last-seen-service.test.ts 1✅ 363ms
src/lib/services/client-metrics/metrics-service-v2.test.ts 3✅ 1s
src/lib/services/client-metrics/schema.test.ts 9✅ 749ms
src/lib/services/client-spec-service.test.ts 2✅ 327ms
src/lib/services/email-service.test.ts 4✅ 474ms
src/lib/services/feature-service-potentially-stale.test.ts 1✅ 2s
src/lib/services/instance-stats-service.test.ts 2✅ 1s
src/lib/services/maintenance-service.test.ts 2✅ 1s
src/lib/services/scheduler-service.test.ts 9✅ 952ms
src/lib/services/state-service.test.ts 30✅ 2s
src/lib/services/tag-schema.test.ts 1✅ 1s
src/lib/services/tag-type-schema.test.ts 3✅ 425ms
src/lib/services/user-service.test.ts 10✅ 3s
src/lib/services/version-service.test.ts 6✅ 2s
src/lib/types/serialize-dates.test.ts 3✅ 216ms
src/lib/types/user.test.ts 7✅ 573ms
src/lib/util/anonymise.test.ts 12✅ 486ms
src/lib/util/anyEventEmitter.test.ts 1✅ 248ms
src/lib/util/arraysHaveSameItems.test.ts 1✅ 228ms
src/lib/util/collapseHourlyMetrics.test.ts 2✅ 763ms
src/lib/util/constantTimeCompare.test.ts 1✅ 2s
src/lib/util/db-lock.test.ts 3✅ 718ms
src/lib/util/ensureStringValue.test.ts 1✅ 472ms
src/lib/util/findDuplicates.test.ts 6✅ 381ms
src/lib/util/flag-resolver.test.ts 8✅ 1s
src/lib/util/format-base-uri.test.ts 6✅ 205ms
src/lib/util/is-email.test.ts 36✅ 373ms
src/lib/util/isDefined.test.ts 1✅ 268ms
src/lib/util/map-values.test.ts 1✅ 179ms
src/lib/util/omit-keys.test.ts 1✅ 293ms
src/lib/util/parseEnvVar.test.ts 3✅ 192ms
src/lib/util/rewriteHTML.test.ts 7✅ 295ms
src/lib/util/semver.test.ts 2✅ 222ms
src/lib/util/snakeCase.test.ts 2✅ 324ms
src/lib/util/time-utils.test.ts 1✅ 618ms
src/lib/util/timer.test.ts 2✅ 318ms
src/lib/util/unique.test.ts 1✅ 323ms
src/lib/util/validateJsonString.test.ts 4✅ 220ms
src/lib/util/validateOrigin.test.ts 1✅ 326ms
src/lib/util/validators/constraint-types.test.ts 8✅ 384ms
src/test/arbitraries.test.ts 2✅ 815ms
src/test/config/create-config.test.ts 9✅ 1s
src/test/e2e/api/admin/addon.e2e.test.ts 16✅ 6s
src/test/e2e/api/admin/api-token.auth.e2e.test.ts 18✅ 11s
src/test/e2e/api/admin/api-token.e2e.test.ts 24✅ 7s
src/test/e2e/api/admin/archive.test.ts 6✅ 6s
src/test/e2e/api/admin/client-metrics.e2e.test.ts 5✅ 7s
src/test/e2e/api/admin/conditional-middleware.e2e.test.ts 4✅ 435ms
src/test/e2e/api/admin/config.e2e.test.ts 4✅ 6s
src/test/e2e/api/admin/constraints.e2e.test.ts 2✅ 5s
src/test/e2e/api/admin/context.e2e.test.ts 18✅ 6s
src/test/e2e/api/admin/environment.test.ts 9✅ 6s
src/test/e2e/api/admin/event.e2e.test.ts 4✅ 6s
src/test/e2e/api/admin/favorites.e2e.test.ts 8✅ 6s
src/test/e2e/api/admin/feature-archive.e2e.test.ts 10✅ 7s
src/test/e2e/api/admin/feature-type.test.ts 6✅ 6s
src/test/e2e/api/admin/feature.auth.e2e.test.ts 2✅ 6s
src/test/e2e/api/admin/feature.custom-auth.e2e.test.ts 2✅ 8s
src/test/e2e/api/admin/feedback.e2e.test.ts 4✅ 7s
src/test/e2e/api/admin/instance-admin.e2e.test.ts 4✅ 6s
src/test/e2e/api/admin/maintenance.e2e.test.ts 4✅ 7s
src/test/e2e/api/admin/metrics.e2e.test.ts 5✅ 6s
src/test/e2e/api/admin/playground.e2e.test.ts 12✅ 11s
src/test/e2e/api/admin/project/api-token.e2e.test.ts 1✅ 6s
src/test/e2e/api/admin/project/environments.e2e.test.ts 7✅ 6s
src/test/e2e/api/admin/project/features.auth.e2e.test.ts 3✅ 7s
src/test/e2e/api/admin/project/features.e2e.test.ts 92✅ 26s
src/test/e2e/api/admin/project/project.api.tokens.e2e.test.ts 8✅ 5s
src/test/e2e/api/admin/project/project.health.e2e.test.ts 8✅ 8s
src/test/e2e/api/admin/project/projects.e2e.test.ts 3✅ 5s
src/test/e2e/api/admin/project/variants.e2e.test.ts 21✅ 8s
src/test/e2e/api/admin/public-signup-token.e2e.test.ts 6✅ 11s
src/test/e2e/api/admin/splash.e2e.test.ts 2✅ 8s
src/test/e2e/api/admin/state.e2e.test.ts 22✅ 10s
src/test/e2e/api/admin/strategy.e2e.test.ts 15✅ 7s
src/test/e2e/api/admin/tag-types.e2e.test.ts 13✅ 7s
src/test/e2e/api/admin/tags.e2e.test.ts 8✅ 7s
src/test/e2e/api/admin/user-admin.e2e.test.ts 20✅ 16s
src/test/e2e/api/admin/user/pat.e2e.test.ts 15✅ 6s
src/test/e2e/api/admin/user/user.test.ts 1✅ 6s
src/test/e2e/api/auth/leading-slashes-are-stripped.e2e.test.ts 4✅ 6s
src/test/e2e/api/auth/reset-password-controller.e2e.test.ts 9✅ 12s
src/test/e2e/api/auth/simple-password-provider.e2e.test.ts 2✅ 10s
src/test/e2e/api/client/feature.e2e.test.ts 10✅ 7s
src/test/e2e/api/client/feature.env.disabled.e2e.test.ts 2✅ 6s
src/test/e2e/api/client/feature.optimal304.e2e.test.ts 3✅ 5s
src/test/e2e/api/client/feature.token.access.e2e.test.ts 4✅ 7s
src/test/e2e/api/client/metrics.e2e.access.e2e.test.ts 1✅ 7s
src/test/e2e/api/client/metrics.e2e.test.ts 3✅ 6s
src/test/e2e/api/client/metricsV2.e2e.test.ts 5✅ 5s
src/test/e2e/api/client/register.e2e.test.ts 2✅ 1⚪ 8s
src/test/e2e/api/client/segment.e2e.test.ts 15✅ 10s
src/test/e2e/api/openapi/openapi.e2e.test.ts 7✅ 14s
src/test/e2e/api/proxy/proxy.concurrency.e2e.test.ts 1✅ 5s
src/test/e2e/api/proxy/proxy.e2e.test.ts 27✅ 11s
src/test/e2e/custom-auth.test.ts 2✅ 4s
src/test/e2e/health.e2e.test.ts 1✅ 6s
src/test/e2e/migrator.e2e.test.ts 1✅ 5s
src/test/e2e/routes/routes.test.ts 4✅ 5s
src/test/e2e/services/access-service.e2e.test.ts 60✅ 1❌ 12s
src/test/e2e/services/addon-service.e2e.test.ts 1✅ 3s
src/test/e2e/services/api-token-service.e2e.test.ts 10✅ 4s
src/test/e2e/services/client-metrics-service.e2e.test.ts 1✅ 8s
src/test/e2e/services/environment-service.test.ts 11✅ 4s
src/test/e2e/services/feature-toggle-service-v2.e2e.test.ts 14✅ 6s
src/test/e2e/services/group-service.e2e.test.ts 9✅ 4s
src/test/e2e/services/last-seen-service.e2e.test.ts 3✅ 3s
src/test/e2e/services/playground-service.test.ts 30✅ 58s
src/test/e2e/services/project-health-service.e2e.test.ts 3✅ 5s
src/test/e2e/services/project-service.e2e.test.ts 47✅ 14s
src/test/e2e/services/reset-token-service.e2e.test.ts 6✅ 5s
src/test/e2e/services/session-service.e2e.test.ts 4✅ 4s
src/test/e2e/services/setting-service.test.ts 3✅ 4s
src/test/e2e/services/state-service.e2e.test.ts 5✅ 4s
src/test/e2e/services/user-service.e2e.test.ts 17✅ 8s
src/test/e2e/stores/client-application-store.e2e.test.ts 6✅ 10s
src/test/e2e/stores/client-metrics-store-v2.e2e.test.ts 14✅ 16s
src/test/e2e/stores/context-field-store.e2e.test.ts 2✅ 5s
src/test/e2e/stores/event-store.e2e.test.ts 8✅ 3s
src/test/e2e/stores/feature-environment-store.e2e.test.ts 2✅ 4s
src/test/e2e/stores/feature-strategies-store.e2e.test.ts 4✅ 3s
src/test/e2e/stores/feature-tag-store.e2e.test.ts 8✅ 3s
src/test/e2e/stores/feature-toggle-client-store.e2e.test.ts 1✅ 7s
src/test/e2e/stores/feature-toggle-store.e2e.test.ts 13✅ 4s
src/test/e2e/stores/feature-type-store.e2e.test.ts 7✅ 5s
src/test/e2e/stores/project-store.e2e.test.ts 7✅ 3s
src/test/e2e/stores/setting-store.e2e.test.ts 7✅ 3s
src/test/e2e/stores/user-feedback-store.e2e.test.ts 5✅ 3s
src/test/e2e/stores/user-splash-store.e2e.test.ts 5✅ 3s
src/test/e2e/stores/user-store.e2e.test.ts 15✅ 3s

❌ src/test/e2e/services/access-service.e2e.test.ts

-should have access to admin addons
  ✅ -should have access to admin addons
-should have access to admin strategies
  ✅ -should have access to admin strategies
-should have access to admin contexts
  ✅ -should have access to admin contexts
-should have access to create projects
  ✅ -should have access to create projects
-should have access to update applications
  ✅ -should have access to update applications
-should not have admin permission
  ✅ -should not have admin permission
-should have project admin to default project as editor
  ✅ -should have project admin to default project as editor
-should not have project admin to other projects as editor
  ✅ -should not have project admin to other projects as editor
-cannot add CREATE_FEATURE without defining project
  ✅ -cannot add CREATE_FEATURE without defining project
-cannot remove CREATE_FEATURE without defining project
  ✅ -cannot remove CREATE_FEATURE without defining project
-should remove CREATE_FEATURE on default environment
  ❌ -should remove CREATE_FEATURE on default environment
	Error: expect(received).toBe(expected) // Object.is equality
-admin should be admin
  ✅ -admin should be admin
-should create default roles to project
  ✅ -should create default roles to project
-should require name when create default roles to project
  ✅ -should require name when create default roles to project
-should grant user access to project
  ✅ -should grant user access to project
-should not get access if not specifying project
  ✅ -should not get access if not specifying project
-should remove user from role
  ✅ -should remove user from role
-should return role with users
  ✅ -should return role with users
-should return role with permissions and users
  ✅ -should return role with permissions and users
-should set root role for user
  ✅ -should set root role for user
-should switch root role for user
  ✅ -should switch root role for user
-should switch project roles on when multiple roles are present for same user
  ✅ -should switch project roles on when multiple roles are present for same user
-should not crash if user does not have permission
  ✅ -should not crash if user does not have permission
-should support permission with "ALL" environment requirement
  ✅ -should support permission with "ALL" environment requirement
-Should have access to create a strategy in an environment
  ✅ -Should have access to create a strategy in an environment
-Should be denied access to create a strategy in an environment the user does not have access to
  ✅ -Should be denied access to create a strategy in an environment the user does not have access to
-Should have access to edit a strategy in an environment
  ✅ -Should have access to edit a strategy in an environment
-Should have access to delete a strategy in an environment
  ✅ -Should have access to delete a strategy in an environment
-Should be denied access to delete a strategy in an environment the user does not have access to
  ✅ -Should be denied access to delete a strategy in an environment the user does not have access to
-Should be denied access to delete a role that is in use
  ✅ -Should be denied access to delete a role that is in use
-Should be denied move feature toggle to project where the user does not have access
  ✅ -Should be denied move feature toggle to project where the user does not have access
-Should be allowed move feature toggle to project when the user has access
  ✅ -Should be allowed move feature toggle to project when the user has access
-Should not be allowed to edit a root role
  ✅ -Should not be allowed to edit a root role
-Should not be allowed to delete a root role
  ✅ -Should not be allowed to delete a root role
-Should not be allowed to edit a project role
  ✅ -Should not be allowed to edit a project role
-Should not be allowed to delete a project role
  ✅ -Should not be allowed to delete a project role
-Should be allowed move feature toggle to project when given access through group
  ✅ -Should be allowed move feature toggle to project when given access through group
-Should not lose user role access when given permissions from a group
  ✅ -Should not lose user role access when given permissions from a group
-Should allow user to take multiple group roles and have expected permissions on each project
  ✅ -Should allow user to take multiple group roles and have expected permissions on each project
-Should allow user to take on root role through a group that has a root role defined
  ✅ -Should allow user to take on root role through a group that has a root role defined
-Should not elevate permissions for a user that is not present in a root role group
  ✅ -Should not elevate permissions for a user that is not present in a root role group
-Should not reduce permissions for an admin user that enters an editor group
  ✅ -Should not reduce permissions for an admin user that enters an editor group
-Should not change permissions for a user in a group without a root role
  ✅ -Should not change permissions for a user in a group without a root role
-Should add permissions to user when a group is given a root role after the user has been added to the group
  ✅ -Should add permissions to user when a group is given a root role after the user has been added to the group
-Should give full project access to the default project to user in a group with an editor root role
  ✅ -Should give full project access to the default project to user in a group with an editor root role
-if user has two roles user has union of permissions from the two roles
  ✅ -if user has two roles user has union of permissions from the two roles
-calling set for user overwrites existing roles
  ✅ -calling set for user overwrites existing roles
-if group has two roles user has union of permissions from the two roles
  ✅ -if group has two roles user has union of permissions from the two roles
-calling set for group overwrites existing roles
  ✅ -calling set for group overwrites existing roles
-group with root role can be assigned a project specific role
  ✅ -group with root role can be assigned a project specific role
-calling add access with invalid project role ids should not assign those roles
  ✅ -calling add access with invalid project role ids should not assign those roles
-calling set roles for user with invalid project role ids should not assign those roles
  ✅ -calling set roles for user with invalid project role ids should not assign those roles
-calling set roles for user with empty role array removes all roles
  ✅ -calling set roles for user with empty role array removes all roles
-calling set roles for user with empty role array should not remove root roles
  ✅ -calling set roles for user with empty role array should not remove root roles
-remove user access should remove all project roles
  ✅ -remove user access should remove all project roles
-remove user access should remove all project roles, while leaving root roles untouched
  ✅ -remove user access should remove all project roles, while leaving root roles untouched
-calling set roles for group with invalid project role ids should not assign those roles
  ✅ -calling set roles for group with invalid project role ids should not assign those roles
-calling set roles for group with empty role array removes all roles
  ✅ -calling set roles for group with empty role array removes all roles
-calling set roles for group with empty role array should not remove root roles
  ✅ -calling set roles for group with empty role array should not remove root roles
-remove group access should remove all project roles
  ✅ -remove group access should remove all project roles
-remove group access should remove all project roles, while leaving root roles untouched
  ✅ -remove group access should remove all project roles, while leaving root roles untouched

Annotations

Check failure on line 378 in src/test/e2e/services/access-service.e2e.test.ts

See this annotation in the file changed.

@github-actions github-actions / Unit Tests

src/test/e2e/services/access-service.e2e.test.ts ► -should remove CREATE_FEATURE on default environment ► -should remove CREATE_FEATURE on default environment

Failed test found in:
  jest-junit.xml
Error:
  Error: expect(received).toBe(expected) // Object.is equality
Raw output
Error: expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true
    at Object.toBe (/home/runner/work/unleash/unleash/src/test/e2e/services/access-service.e2e.test.ts:378:7)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)