Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NetworkObject.DeferDespawn not respecting DestroyGameObject parameter #3219

Merged
merged 8 commits into from
Feb 5, 2025
Merged

fix: NetworkObject.DeferDespawn not respecting DestroyGameObject parameter #3219

merged 8 commits into from
Feb 5, 2025

Conversation

EmandM
Copy link
Collaborator

@EmandM EmandM commented Jan 31, 2025

Ensure that DeferDespawn respects the DestroyGameObject parameter for in-scene placed network objects.

Add unit and integration tests around deferred despawning.

MTTB-972

Changelog

  • Fixed: Pass the DestroyGameObject parameter correctly through the DeferDespawn codepath

Testing and Documentation

  • Includes unit tests.
  • Includes integration tests.

@EmandM EmandM requested a review from a team as a code owner January 31, 2025 20:06
NoelStephensUnity and others added 7 commits February 3, 2025 10:28
@NoelStephensUnity
test-fix
16659e8 
Checking to see if the failure was due to the network prefab being spawned when the host-server starts.
@NoelStephensUnity
test-fix
233c1b3 
Assure all NetworkManagers are destroyed at the end of TearDown.
@NoelStephensUnity
Revert "test-fix"
f18beb7 
This reverts commit 16659e8.
@NoelStephensUnity
test-fix-fix
cf62c80 
Fixing the bug in my previous fix.
@EmandM
Ensure DeferDespawn tick is always reset
40b3c20
@EmandM
revert DestroyObject message change
f973dfc
@NoelStephensUnity
Update CHANGELOG.md
7a4eaf1 
Adding PR number to changelog entry.
NoelStephensUnity
NoelStephensUnity approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added PR number to change log entry.
Other than that, looks good to me!
👍

@NoelStephensUnity NoelStephensUnity merged commit 2eee998 into develop-2.0.0 Feb 5, 2025
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/MTTB-972-DeferDespawn-DestroyGameObject branch February 5, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EmandM @NoelStephensUnity