Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum resolving to wrong integers (ISXB-1270) #2100

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

adrian-koretski-unity3d
Copy link
Collaborator

Description

Issue arises from enum values that do not correspond to their index in the array (such as the triggers). The fix is to map the index values to the enum values.

Testing status & QA

Tested by selecting the problematic values in editor and verifying that they correctly select the associated enum values.

Overall Product Risks

Low risk

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

After merge:

  • Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.

…alues not matching displayed dropdown values in editor when using GamepadButtonPropertyDrawer.
Copy link
Collaborator

@ekcoh ekcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow the logical changes to the property drawer completely, but if this successfully resolved string to value mapping for the property drawer editor it's all good to me. Maybe add some inline comments to the code explaining what you achieve with the added SetEnumDisplayNames for readability?

@ekcoh ekcoh requested a review from Pauliusd01 January 17, 2025 08:19
@ekcoh
Copy link
Collaborator

ekcoh commented Jan 17, 2025

Added QA representative to PR for testing. Recommend looking for consistent mapping among all entries of the enum.

@adrian-koretski-unity3d adrian-koretski-unity3d changed the title Fixed GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum v… FIX: GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum v… Jan 22, 2025
@Pauliusd01 Pauliusd01 changed the title FIX: GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum v… FIX: GamepadButton.LeftTrigger and GamepadButton.RightTrigger enum resolving to wrong integers (ISXB-1270) Jan 23, 2025
@adrian-koretski-unity3d adrian-koretski-unity3d merged commit ff2ac9d into develop Jan 24, 2025
95 checks passed
@adrian-koretski-unity3d adrian-koretski-unity3d deleted the Fix__ISXB-1273 branch January 24, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants