Uncrispify ColumnsForm

[stveit]

Fixes #3100

Not sure if the form_action value is correct. tried to set it to reverse('webfront-preferences-setwidgetcolumns') directly but that created some errors, but just giving the string without reversing seems to have worked fine?

We dont have a separate uncrispy class for NavSubmit, but it seems a NavSubmit button is pretty much just a smaller submit button using the css classes button small, so I just used a SubmitField with the additional css.
Is it even necessary to include button as a class? It seems to look and behave exactly the same with just small

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	992		0	10.87s
✅ PYTHON	ruff	987		0	0.11s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    9 files      9 suites   8m 30s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 967abd4.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (94633a6) to head (967abd4).
Report is 290 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3108      +/-   ##
==========================================
- Coverage   60.47%   60.44%   -0.03%     
==========================================
  Files         605      605              
  Lines       43773    43765       -8     
  Branches       48       48              
==========================================
- Hits        26472    26455      -17     
- Misses      17289    17298       +9     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[johannaengland]

I can confirm that this works (I even checked in the database that the value was actually changed).

[johannaengland]

The submit field already sets the css class button, so this should be enough:

Suggested change

	SubmitField(value='Save', css_classes='button small'),
	SubmitField(value='Save', css_classes='small'),

[podliashanyk]

Looks good!
reverse is redundant since we do not process path name in python, instead we use url in the form template to get url path when given name

nav/python/nav/web/templates/custom_crispy_templates/flat_form.html

Line 2 in 761efa7

{% if form.attrs.action %}action="{% url form.attrs.action %}"{% endif %}

Have tested it manually and it works like the original implementation. Which to me seems broken given that it doesn't update the number of columns in the UI on success.

Also see @johannaengland comment about the class name.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud