Uncrispify MacWatchForm #3110
Uncrispify MacWatchForm #3110
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 9 files 9 suites 8m 8s ⏱️ Results for commit d3a9d7e. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3110 +/- ##
==========================================
- Coverage 60.44% 60.44% -0.01%
==========================================
Files 605 605
Lines 43765 43757 -8
Branches 48 48
==========================================
- Hits 26455 26447 -8
Misses 17298 17298
Partials 12 12 ☔ View full report in Codecov by Sentry. |
| @@ -37,11 +35,14 @@ class MacWatchForm(forms.Form): | |||
|
|
|||
| def __init__(self, *args, **kwargs): | |||
| super(MacWatchForm, self).__init__(*args, **kwargs) | |||
| self.helper = FormHelper() | |||
| self.helper.form_action = '.' | |||
There was a problem hiding this comment.
Do you know if it matters that this form_action is removed? Seems pretty strange to me
There was a problem hiding this comment.
It seems like it does nothing tbh, everything works fine as far as I can tell
There was a problem hiding this comment.
There could have been a difference if there wasn't a trailing slash in the URL https://stackoverflow.com/a/32076661.
Unless this form is used as a widget on main page (which renders without trailing slash), there shouldn't be a problem with removing form_action here.
stveit
force-pushed
the
uncrispify/MacWatchForm
branch
from
f417308
to
d3a9d7e
Compare
|
|
Rebased on master since #3108 was merged so I could remove |
There was a problem hiding this comment.
Looks good to me! But I would still wait for @podliashanyk's review before merging.
| @@ -37,11 +35,14 @@ class MacWatchForm(forms.Form): | |||
|
|
|||
| def __init__(self, *args, **kwargs): | |||
| super(MacWatchForm, self).__init__(*args, **kwargs) | |||
| self.helper = FormHelper() | |||
| self.helper.form_action = '.' | |||
There was a problem hiding this comment.
There could have been a difference if there wasn't a trailing slash in the URL https://stackoverflow.com/a/32076661.
Unless this form is used as a widget on main page (which renders without trailing slash), there shouldn't be a problem with removing form_action here.
Fixes #3109
when this and #3108 is merged then
NavSubmitcan be removed (realistically the one that is merged last will also delete it)Urls:
http://localhost/macwatch/add/