Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncrispyfy ManagementProfileFilterForm in SeedDB #3092

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #3061.

Also removes crispy helpers that were only used by that form by now.

Copy link

github-actions bot commented Oct 4, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.26s
✅ PYTHON ruff 987 0 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Oct 4, 2024

Test results

    9 files      9 suites   8m 8s ⏱️
2 136 tests 2 136 ✅ 0 💤 0 ❌
4 011 runs  4 011 ✅ 0 💤 0 ❌

Results for commit 63fde94.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.43%. Comparing base (fb350b8) to head (63fde94).
Report is 299 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
- Coverage   60.45%   60.43%   -0.02%     
==========================================
  Files         605      605              
  Lines       43792    43776      -16     
  Branches       48       48              
==========================================
- Hits        26474    26458      -16     
  Misses      17306    17306              
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stveit stveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing the filter, it doesnt actually seem to filter properly. It always returns SNMP protocols and ignores whatever protocol you try to set in the filter. Changing method to GET (see comment) fixed it for me.

My local NAV instance started acting weird while testing, so I would suggest you test as well to see if you experience the same behaviour

python/nav/web/seeddb/page/management_profile/forms.py Outdated Show resolved Hide resolved
@johannaengland johannaengland requested a review from stveit October 7, 2024 12:20
@johannaengland johannaengland force-pushed the refactor/uncrispify-management-profile-filter-form branch from 8ad502e to 63fde94 Compare October 7, 2024 13:29
Copy link

sonarqubecloud bot commented Oct 7, 2024

@johannaengland johannaengland merged commit fcaaa6d into master Oct 8, 2024
12 of 13 checks passed
@johannaengland johannaengland deleted the refactor/uncrispify-management-profile-filter-form branch October 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncrispyfy ManagementProfileFilterForm in SeedDB
2 participants