-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncrispyfy ManagementProfileFilterForm
in SeedDB
#3092
Uncrispyfy ManagementProfileFilterForm
in SeedDB
#3092
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 8s ⏱️ Results for commit 63fde94. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3092 +/- ##
==========================================
- Coverage 60.45% 60.43% -0.02%
==========================================
Files 605 605
Lines 43792 43776 -16
Branches 48 48
==========================================
- Hits 26474 26458 -16
Misses 17306 17306
Partials 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When testing the filter, it doesnt actually seem to filter properly. It always returns SNMP protocols and ignores whatever protocol you try to set in the filter. Changing method to GET (see comment) fixed it for me.
My local NAV instance started acting weird while testing, so I would suggest you test as well to see if you experience the same behaviour
8ad502e
to
63fde94
Compare
Quality Gate passedIssues Measures |
Closes #3061.
Also removes crispy helpers that were only used by that form by now.