Use new helper function for management profile filter form in seedDB #3127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannaengland
requested review from
lunkwill42,
hmpf,
stveit and
podliashanyk
johannaengland
changed the base branch from
master
to
refactor/switch-seeddb-filter-form-to-new-way
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Test results 8 files 8 suites 8m 21s ⏱️ Results for commit 81689b3. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3127 +/- ##
=======================================
Coverage 60.44% 60.44%
=======================================
Files 605 605
Lines 43749 43749
Branches 48 48
=======================================
Hits 26443 26443
Misses 17294 17294
Partials 12 12 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
refactor/use-get-single-layout-management-filter-form
branch
from
59a8276 to
d9274ac
Compare
stveit
approved these changes
Oct 10, 2024
johannaengland
force-pushed
the
refactor/switch-seeddb-filter-form-to-new-way
branch
2 times, most recently
from
c383bb7 to
d037671
Compare
Base automatically changed from
refactor/switch-seeddb-filter-form-to-new-way
to
master
October 11, 2024 09:56
johannaengland
force-pushed
the
refactor/use-get-single-layout-management-filter-form
branch
from
d9274ac to
81689b3
Compare
|
johannaengland
deleted the
refactor/use-get-single-layout-management-filter-form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts changes done in #3092. Makes sure that all things in seedDB that have been uncrispified use the same way.
Dependent on #3126.