Remove unused test variables

[johannaengland]

Just like #3028 and #3029 another part in adding F841 to ruff.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	black	992		0	11.24s
✅ PYTHON	ruff	987		0	0.09s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

[github-actions]

Test results

    7 files      7 suites   4m 31s ⏱️
2 128 tests 2 127 ✅ 0 💤 1 ❌
2 956 runs  2 954 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 3650463.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (5d6feef) to head (3650463).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         605      605           
  Lines       43816    43816           
  Branches       48       48           
=======================================
  Hits        26497    26497           
  Misses      17307    17307           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lunkwill42]

That failed pretty fast. I know this was my suggestion, but I must have hallucinated it. I might have built such thing myself at some point. While modules like itertools have lots of little utilities to deal with iterators, this wasn't one of them.

You could use collections.deque with a maximum length of 0 as a fast way to explicitly exhaust a generator, although it doesn't read as well:

Suggested change

	itertools.consume(b)
	deque(b, maxlen=0)

[lunkwill42]

or, you could keep using the original list statement and add a short comment as to why, so people don't read it and scratch their heads...