Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unused variable rule (F841) to ruff #3035

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

As #3026, up for discussion. This also adds F842 - Local variable {name} is annotated but never used.

Dependent on #3033, #3029 and #3028.

@johannaengland johannaengland added the discussion Requires developer feedback/discussion before implementation label Sep 25, 2024
@johannaengland johannaengland self-assigned this Sep 25, 2024
Copy link

sonarcloud bot commented Sep 25, 2024

Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 992 0 11.05s
❌ PYTHON ruff 987 35 0.1s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

Test results

    9 files      9 suites   8m 35s ⏱️
2 128 tests 2 128 ✅ 0 💤 0 ❌
3 995 runs  3 995 ✅ 0 💤 0 ❌

Results for commit 73971f4.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (5d6feef) to head (73971f4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3035   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         605      605           
  Lines       43816    43816           
  Branches       48       48           
=======================================
  Hits        26497    26497           
  Misses      17307    17307           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked discussion Requires developer feedback/discussion before implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant