Refactor CI #406
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # We want to only run doctests on a single version of Julia, because | ||
| # things like error messages / output can change between versions and | ||
| # is fragile to test against. | ||
| name: Doctests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| merge_group: | ||
| types: [checks_requested] | ||
|
|
||
| # needed to allow julia-actions/cache to delete old caches that it has created | ||
| permissions: | ||
| actions: write | ||
| contents: read | ||
|
|
||
| # Cancel existing tests on the same PR if a new commit is added to a pull request | ||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref || github.run_id }} | ||
| cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }} | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: julia-actions/setup-julia@v2 | ||
| with: | ||
| version: '1' | ||
|
|
||
| - uses: julia-actions/cache@v2 | ||
|
|
||
| - uses: julia-actions/julia-buildpkg@v1 | ||
|
|
||
| - uses: julia-actions/julia-runtest@v1 | ||
| env: | ||
| GROUP: Doctests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,35 +1,37 @@ | ||
| using Enzyme: ForwardMode | ||
|
|
||
| @testset "VecCorrBijector: $backend_name" for (backend_name, adtype) in TEST_ADTYPES | ||
| @testset "d = $d" for d in (1, 2, 4) | ||
| dist = LKJ(d, 2.0) | ||
| b = bijector(dist) | ||
| binv = inverse(b) | ||
|
|
||
| x = rand(dist) | ||
| y = b(x) | ||
|
|
||
| # roundtrip | ||
| test_ad(y -> sum(transform(b, binv(y))), adtype, y) | ||
| # inverse only | ||
| test_ad(y -> sum(transform(binv, y)), adtype, y) | ||
| end | ||
| end | ||
|
|
||
| @testset "VecCholeskyBijector: $backend_name" for (backend_name, adtype) in TEST_ADTYPES | ||
| @testset "d = $d, uplo = $uplo" for d in (1, 2, 4), uplo in ('U', 'L') | ||
| dist = LKJCholesky(d, 2.0, uplo) | ||
| b = bijector(dist) | ||
| binv = inverse(b) | ||
|
|
||
| x = rand(dist) | ||
| y = b(x) | ||
| cholesky_to_triangular = | ||
| uplo == 'U' ? Bijectors.cholesky_upper : Bijectors.cholesky_lower | ||
|
|
||
| # roundtrip | ||
| test_ad(y -> sum(transform(b, binv(y))), adtype, y) | ||
| # inverse (we need to tack on `cholesky_upper`/`cholesky_lower`, | ||
| # because directly calling `sum` on a LinearAlgebra.Cholesky doesn't | ||
| # give a scalar) | ||
| test_ad(y -> sum(cholesky_to_triangular(transform(binv, y))), adtype, y) | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,51 +1,60 @@ | ||
| module BijectorsEnzymeRulesTests | ||
|
|
||
| using Bijectors | ||
| using Enzyme | ||
| using EnzymeTestUtils: test_forward, test_reverse | ||
| using Test | ||
|
|
||
| # This entire test suite is broken on 1.11. | ||
| # | ||
| # https://github.com/EnzymeAD/Enzyme.jl/issues/2121 | ||
| # https://github.com/TuringLang/Bijectors.jl/pull/350#issuecomment-2470766968 | ||
| # | ||
| # Ideally we'd use `@test_throws`. However, that doesn't work because | ||
| # `test_forward` itself calls `@test`, and the error is captured by that | ||
| # `@test`, not our `@test_throws`. Consequently `@test_throws` doesn't actually | ||
| # see any error. Weird Julia behaviour. | ||
|
|
||
| @static if VERSION < v"1.11" | ||
| @testset "Enzyme: Bijectors.find_alpha" begin | ||
| x = randn() | ||
| y = expm1(randn()) | ||
| z = randn() | ||
|
|
||
| @testset "forward" begin | ||
| # No batches | ||
| @testset for RT in (Const, Duplicated, DuplicatedNoNeed), | ||
| Tx in (Const, Duplicated), | ||
| Ty in (Const, Duplicated), | ||
| Tz in (Const, Duplicated) | ||
|
|
||
| test_forward(Bijectors.find_alpha, RT, (x, Tx), (y, Ty), (z, Tz)) | ||
| end | ||
|
|
||
| # Batches | ||
| @testset for RT in (Const, BatchDuplicated, BatchDuplicatedNoNeed), | ||
| Tx in (Const, BatchDuplicated), | ||
| Ty in (Const, BatchDuplicated), | ||
| Tz in (Const, BatchDuplicated) | ||
|
|
||
| test_forward(Bijectors.find_alpha, RT, (x, Tx), (y, Ty), (z, Tz)) | ||
| end | ||
| end | ||
| @testset "reverse" begin | ||
| # No batches | ||
| @testset for RT in (Const, Active), | ||
| Tx in (Const, Active), | ||
| Ty in (Const, Active), | ||
| Tz in (Const, Active) | ||
|
|
||
| test_reverse(Bijectors.find_alpha, RT, (x, Tx), (y, Ty), (z, Tz)) | ||
| end | ||
|
|
||
| # TODO: Test batch mode | ||
| # This is a bit problematic since Enzyme does not support all combinations of activities currently | ||
| # https://github.com/TuringLang/Bijectors.jl/pull/350#issuecomment-2480468728 | ||
| end | ||
| end | ||
| end | ||
|
|
||
| end |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a replacement for
strict=falsewhich no longer works with Documenter.jl v1.0. It converts all docs errors into warnings. This is not good, but I didn't want fix this in this PR as well, it should be a separate PR.