Refactor CI #406
Refactor CI #406
Conversation
|
Bijectors.jl documentation for PR #406 is available at: |
|
Well look at that those green ticks, not had that for a while on Bijectors. |
.github/workflows/Interface.yml
Outdated
There was a problem hiding this comment.
Subsumed into CI.yml.
| # TODO: Remove this | ||
| warnonly=true, |
There was a problem hiding this comment.
This is a replacement for strict=false which no longer works with Documenter.jl v1.0. It converts all docs errors into warnings. This is not good, but I didn't want fix this in this PR as well, it should be a separate PR.
| @@ -29,43 +34,6 @@ end | |||
| test_frule(Bijectors.find_alpha, x, y, z) | |||
| test_rrule(Bijectors.find_alpha, x, y, z) | |||
|
|
|||
| if @isdefined Mooncake | |||
There was a problem hiding this comment.
moved to test/ad/mooncake.jl
| @@ -108,19 +108,3 @@ function test_functor(x, xs) | |||
| @test x == re(_xs) | |||
| @test _xs == xs | |||
| end | |||
|
|
|||
| function test_bijector_parameter_gradient(b::Bijectors.Transform, x, y=b(x)) | |||
There was a problem hiding this comment.
this function was not being used anywhere so can be deleted
test/ad/utils.jl
Outdated
There was a problem hiding this comment.
this file is no longer needed, the test_ad function is directly defined in test/runtests.jl
This PR reworks most of Bijectors' CI setup to be more manageable.
Use DifferentiationInterface instead of directly calling
ForwardDiff.gradient, etc.Test all AD backends in a single CI job. The tests don't take very long at all so this is not a problem in terms of time. It also allows us to restructure the
test_adfunction so that we can more surgically disable / enable tests. The previous one was very awkward to work with.Disable / enable failing Enzyme tests as needed to make CI pass without the use of
continue-on-error. Where possible we use@test_throwsinstead of just skipping the test as that will let us know if and when a test begins to workSeparate doctests into a standalone CI job that only runs on 1.11. Doctest output can depend on Julia version so it can be very fragile running doctests on multiple different CI setups.
Cache the Julia environment in CI. Saves time.
Add a couple of CI runners on Windows.
Closes #373
Closes #347 (not directly, but I think the intent behind that was really 'clean up the Enzyme tests', and this PR does so)