Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minor version to 0.15 #353

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Bump minor version to 0.15 #353

merged 5 commits into from
Nov 28, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Nov 28, 2024

Raises minimum Julia version to v1.10 and bumps EnzymeCore compat to latest, with the manual find_alpha rule.

Could also bump the minor, rather than patch, version, because of the changing Julia compat. This shouldn't cause breakage for anyone who manages to install it, so in that sense it's not breaking, but bumping Julia versions could still be considered a "major" thing. Do we have a convention for this in Julia-land or Turing-land? EDIT: See later comments, decided to go with a minor

@mhauru mhauru requested review from yebai and penelopeysm November 28, 2024 09:29
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@yebai
Copy link
Member

yebai commented Nov 28, 2024

Perhaps address #347 before releasing so future PRs don't get broken CI status.

Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compat was already bumped in 0.14.0 so bumping patch on this is fine

@penelopeysm
Copy link
Member

@yebai The new rule fixes the Interface tests, so the only failing ones are AD/Enzyme. There isn't any requirement that any CI test passes for PRs (https://github.com/TuringLang/Bijectors.jl/settings/branches), so we can just ignore the AD/Enzyme ones when making PRs?

We could hide the red cross (e.g. by not running the tests, or by using continue-on-error: true) but I would rather not do this as it's easy to forget to undo

@yebai
Copy link
Member

yebai commented Nov 28, 2024

Given the fragility of Enzyme (e.g. compatibility with new Julia releases or other libraries), we would like to test Enzyme in a new (isolated) test environment, which avoids loading Enzyme in the runtests.jlscript.

For example, we have been using isolated environments for integration testing in Mooncake, see here.

@penelopeysm
Copy link
Member

That's a fair way of guarding against errors-on-import spoiling the non-Enzyme jobs, but it doesn't help us with errors-on-use. As long as Enzyme is tested in some CI job, there will be a red cross, so doing this won't affect the CI status of new PRs unless we either disable testing or explicitly hide the red cross with continue-on-error.

@yebai
Copy link
Member

yebai commented Nov 28, 2024

That's a fair way of guarding against errors-on-import spoiling the non-Enzyme jobs, but it doesn't help us with errors-on-use.

That's true, but it's still helpful. It prevents non-Enzyme CIs from frequently breaking due to loading Enzyme.

explicitly hide the red cross with continue-on-error.

I think it is okay to enable continue-on-error for the Enzyme CI task. We do this trick in other settings, e.g., JuliaPre releases. It is very helpful for us to monitor these failed tests on CI, but we will only need to worry about them once the relevant package becomes stable.

@penelopeysm
Copy link
Member

This should give us back the green tick. It doesn't fix the possibility of error-on-import, but that's not currently a problem (as the extension stuff was fixed) so that can be for another time imo

@mhauru
Copy link
Member Author

mhauru commented Nov 28, 2024

Compat was already bumped in 0.14.0 so bumping patch on this is fine

1.4.2 seems to still say v1.6: https://github.com/TuringLang/Bijectors.jl/blob/v0.14.2/Project.toml#L73

Thanks for the help here @penelopeysm! @yebai, are you happy to leave guarding against the error-on-import stuff for later?

@yebai
Copy link
Member

yebai commented Nov 28, 2024

Thanks for the help here @penelopeysm! @yebai, are you happy to leave guarding against the error-on-import stuff for later?

Yes, please add a clarification on this remaining issue in #347

@penelopeysm
Copy link
Member

still say v1.6: https://github.com/TuringLang/Bijectors.jl/blob/v0.14.2/Project.toml#L73

Wut, I guess this got lost somewhere in the bunch of PRs.

Anyway we decided that a minor bump is more appropriate for Julia compat bumps:

#342

So maybe this should be 0.15.0. I don't know what happened to that PR and why it got lost.

@mhauru mhauru changed the title Bump patch version to 0.14.3. Bump minor version to 0.15 Nov 28, 2024
@mhauru
Copy link
Member Author

mhauru commented Nov 28, 2024

Now bumping to 0.15.

@mhauru mhauru merged commit d342371 into master Nov 28, 2024
33 checks passed
@mhauru mhauru deleted the mhauru/v0.14.3 branch November 28, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants