Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for pre-1.10 #129

Merged
merged 34 commits into from
Dec 3, 2024
Merged

Drop support for pre-1.10 #129

merged 34 commits into from
Dec 3, 2024

Conversation

Red-Portal
Copy link
Member

@Red-Portal Red-Portal commented Oct 8, 2024

  • Change CI to test only on 1.10 and 1
  • Remove all uses to SimpleUnPack in favor of the (; ret1, ret2) = func() syntax.
  • Separate Enzyme into its own CI workflow.
  • Wait until the upstream (Julia) bugfixes get shipped.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: 065d1e3 Previous: 0730cd9 Ratio
normal/RepGradELBO + STL/meanfield/Zygote 15120370759 ns 14902942884 ns 1.01
normal/RepGradELBO + STL/meanfield/ForwardDiff 3172497915 ns 3366889661 ns 0.94
normal/RepGradELBO + STL/meanfield/ReverseDiff 3221260760 ns 3326105688 ns 0.97
normal/RepGradELBO + STL/fullrank/Zygote 14739992755 ns 14847911192 ns 0.99
normal/RepGradELBO + STL/fullrank/ForwardDiff 3462921772 ns 3617588303 ns 0.96
normal/RepGradELBO + STL/fullrank/ReverseDiff 5781026271 ns 5788188691 ns 1.00
normal/RepGradELBO/meanfield/Zygote 7117697235 ns 7121546498 ns 1.00
normal/RepGradELBO/meanfield/ForwardDiff 2355746121.5 ns 2413222821 ns 0.98
normal/RepGradELBO/meanfield/ReverseDiff 1477804875 ns 1531607476 ns 0.96
normal/RepGradELBO/fullrank/Zygote 7145113353 ns 7158692073 ns 1.00
normal/RepGradELBO/fullrank/ForwardDiff 2529502325 ns 2625054567 ns 0.96
normal/RepGradELBO/fullrank/ReverseDiff 2563602594 ns 2646630673 ns 0.97
normal + bijector/RepGradELBO + STL/meanfield/Zygote 22953097561 ns 22671313390 ns 1.01
normal + bijector/RepGradELBO + STL/meanfield/ForwardDiff 11221192990 ns 8814087077 ns 1.27
normal + bijector/RepGradELBO + STL/meanfield/ReverseDiff 5068453002 ns 4620405690 ns 1.10
normal + bijector/RepGradELBO + STL/fullrank/Zygote 22949690140 ns 23085067529 ns 0.99
normal + bijector/RepGradELBO + STL/fullrank/ForwardDiff 10359266119 ns 9162458670 ns 1.13
normal + bijector/RepGradELBO + STL/fullrank/ReverseDiff 8138707126 ns 7742623379 ns 1.05
normal + bijector/RepGradELBO/meanfield/Zygote 14698024511 ns 14546492604 ns 1.01
normal + bijector/RepGradELBO/meanfield/ForwardDiff 8654412641 ns 7674494881 ns 1.13
normal + bijector/RepGradELBO/meanfield/ReverseDiff 3109684149 ns 2707868163 ns 1.15
normal + bijector/RepGradELBO/fullrank/Zygote 14845112996 ns 14527995995 ns 1.02
normal + bijector/RepGradELBO/fullrank/ForwardDiff 9425184412 ns 7983772081 ns 1.18
normal + bijector/RepGradELBO/fullrank/ReverseDiff 4478465691 ns 4101431907 ns 1.09

This comment was automatically generated by workflow using github-action-benchmark.

@Red-Portal Red-Portal added this to the v0.3.0 milestone Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (616b581) to head (065d1e3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   93.54%   91.93%   -1.62%     
==========================================
  Files          12       12              
  Lines         372      372              
==========================================
- Hits          348      342       -6     
- Misses         24       30       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Red-Portal
Copy link
Member Author

There was an upstream bug that got caught. For this to be fixed, we'll need to wait until Julia 1.11.2.

test/runtests.jl Outdated Show resolved Hide resolved
@Red-Portal
Copy link
Member Author

@yebai Everything finally works except for Enzyme. Shall we proceed to merging?

@yebai yebai merged commit 227d58d into master Dec 3, 2024
13 of 19 checks passed
@yebai yebai deleted the drop_support_1.6_lts branch December 3, 2024 08:06
@yebai
Copy link
Member

yebai commented Dec 3, 2024

Thanks, @Red-Portal, for the nice improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants