Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #2

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

dev -> main #2

wants to merge 41 commits into from

Conversation

0xKurt
Copy link
Collaborator

@0xKurt 0xKurt commented Sep 27, 2022

No description provided.

@0xKurt 0xKurt requested a review from paxthemax September 27, 2022 13:44
@aminlatifi
Copy link

The contracts look fine. Not reviewed tests!

@daithi-coombes
Copy link

I'm trying to fully understand the problem to be solved. Is there somewhere I can find more info?

namely why not RBAC roles (openzeppelin) - as that framework is used extensively and the resulting code to implement could be greatly reduced. Unless maybe AdminRole is required to be bespoke due to its core security importance?

basically... ☝️ empty ticket :trollface: 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants