Skip to content

Conversation

@shenxiangzhuang
Copy link
Contributor

@shenxiangzhuang shenxiangzhuang commented Jan 12, 2025

Fix the mypy errors from numpy and attrs.

Checklist

  • I have read the CONTRIBUTING document
  • I hereby agree to the terms of either individual CLA available at: https://toloka.ai/legal/cla_individual or corporate CLA available at: https://toloka.ai/legal/cla_corporate, whichever is applicable to me, as it pertains to direct contributions to crowd-kit only
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@dustalov
Copy link
Collaborator

Hi, thank you for the fix. However, the issue seems more complex than expected. Could you please fix the root cause of the error?

@dustalov dustalov mentioned this pull request Jan 12, 2025
6 tasks
@shenxiangzhuang shenxiangzhuang changed the title ci(mypy): remove attrs type ignore ci(mypy): fix mypy errors from numpy and attrs libs Jan 13, 2025
@shenxiangzhuang
Copy link
Contributor Author

Hi, @dustalov . I have fixed these mypy errors and it works well according to the ci status. Please review it later~

@dustalov dustalov merged commit 6f47e4d into Toloka:main Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants