Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: held status after fail #344

Merged
merged 1 commit into from
Jul 4, 2023
Merged

feat: held status after fail #344

merged 1 commit into from
Jul 4, 2023

Conversation

PaulFarault
Copy link
Contributor

Which issue(s) this PR fixes

Fixes #337

Additional comments

I also added some comments and refactored some of the variables to improve code comprehension.

Agreements

@PaulFarault PaulFarault linked an issue Jul 3, 2023 that may be closed by this pull request
Operations status remain PLANNED even after a FAILURE #337
Closed
@sergkudinov
Copy link
Contributor

When operations complete with SUCCESS in the middle of a deployment execution and the deployment is interrupted (by CTRL + C for example), the deplyment keeps status RUNNING and the rest of operations keep PLANNED.

It is easy to reproduce in --mock-deploy:

  1. tdp plan dag
  2. tdp deploy --mock-deploy
  3. Interrupt with CTRL+C in the middle

Probably, it also works when interrupted in between of operations in real mode.

sergkudinov
sergkudinov requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@sergkudinov sergkudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add functionality described in my comment above

@PaulFarault
Copy link
Contributor Author

@sergkudinov that's an other issue: #340

@sergkudinov sergkudinov self-requested a review July 4, 2023 11:44
@sergkudinov sergkudinov mentioned this pull request Jul 4, 2023
Merged
2 tasks
mdrutel
mdrutel approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@mdrutel mdrutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is OK

@PaulFarault PaulFarault merged commit c6baf59 into master Jul 4, 2023
@PaulFarault PaulFarault deleted the 337-operations-status-remain-planned-even-after-a-failure branch July 4, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrutel mdrutel mdrutel approved these changes

@sergkudinov sergkudinov sergkudinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operations status remain PLANNED even after a FAILURE
3 participants
@PaulFarault @sergkudinov @mdrutel