Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken tests #339

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix broken tests #339

merged 1 commit into from
Jul 4, 2023

Conversation

sergkudinov
Copy link
Contributor

@sergkudinov sergkudinov commented Jun 29, 2023 •
edited
Loading

Which issue(s) this PR fixes

Fixes #333

Agreements

@sergkudinov
Copy link
Contributor Author

sergkudinov commented Jun 29, 2023 •
edited
Loading

In ./tdp, 3 tests are not currently passing because of #337:

  • test_failed_operation_stops
  • test_deployment_is_resumed
  • test_deployment_reconfigure_is_resumed

@sergkudinov sergkudinov requested a review from PaulFarault June 29, 2023 14:45
PaulFarault
PaulFarault requested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Make sure to remove the Fixes from your comment so it won't close the issue (we still have to fix the code and the remaining tests).

tdp/core/deployment/deployment_iterator.py Outdated Show resolved Hide resolved
tdp/core/deployment/deployment_plan.py Outdated Show resolved Hide resolved
@PaulFarault PaulFarault mentioned this pull request Jun 30, 2023
Closed
@PaulFarault
Copy link
Contributor

@sergkudinov Do you prefer to merge this one "now" and do a second pr later to fix the remaining tests or do you want to wait for the #337 to be fixed?

@sergkudinov
Copy link
Contributor Author

@PaulFarault we can wait, it doesn't block anything

@sergkudinov sergkudinov force-pushed the 333-fix-broken-tests branch from 5d170a9 to 3c2b93c Compare June 30, 2023 13:24
@jpsavy jpsavy self-requested a review June 30, 2023 14:48
@sergkudinov sergkudinov force-pushed the 333-fix-broken-tests branch from 3c2b93c to 078c5be Compare July 4, 2023 11:54
@sergkudinov
Copy link
Contributor Author

sergkudinov commented Jul 4, 2023 •
edited
Loading

I checked this changes on #344 PR's branch, it works. Just waiting #344 merged to master...

@sergkudinov sergkudinov requested a review from PaulFarault July 4, 2023 12:19
PaulFarault

This comment was marked as outdated.

Sign in to view

PaulFarault
PaulFarault requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually no, idk why I've approved. There are still 3 tests that are not passing.

@sergkudinov
Copy link
Contributor Author

@PaulFarault
it works on my computer
43 of 43 passed

@sergkudinov sergkudinov force-pushed the 333-fix-broken-tests branch from 078c5be to 781ae26 Compare July 4, 2023 13:07
@sergkudinov
Copy link
Contributor Author

just rebased on latest master

PaulFarault
PaulFarault approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it works now.

@sergkudinov sergkudinov merged commit 0f7df25 into master Jul 4, 2023
@sergkudinov sergkudinov deleted the 333-fix-broken-tests branch July 4, 2023 13:25
@mdrutel mdrutel requested review from mdrutel and removed request for mdrutel July 4, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpsavy jpsavy jpsavy approved these changes

@PaulFarault PaulFarault PaulFarault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] Fix broken tests from the plan command
3 participants
@sergkudinov @PaulFarault @jpsavy