Task/WP-32: onboarding page filter incomplete users #890
Conversation
Codecov Report
@@ Coverage Diff @@
## main #890 +/- ##
==========================================
+ Coverage 63.36% 63.39% +0.02%
==========================================
Files 429 430 +1
Lines 12271 12300 +29
Branches 2532 2543 +11
==========================================
+ Hits 7776 7797 +21
- Misses 4288 4294 +6
- Partials 207 209 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asimregmi
changed the title
asimregmi
requested review from
sophia-massie
and removed request for
wesleyboar
There was a problem hiding this comment.
It looks like the git history is showing that this branch was off your datafiles PR (WP-66) instead of main. You may need to create a fresh branch off of main and add only the onboarding changes that apply to the WP-32 task for a clean commit history.
Accidentally branching off another branch is easy to accidentally do. It can be tricky so ping me if you have questions. Make sure you get a fresh main branch
You could also pull main into this branch since we squash commits anyway and save you some work.
|
I see the issue. Thank you @sophia-massie . Been trying to rebase for an hour. I will fix it. Thanks :) |
| @@ -233,11 +234,24 @@ OnboardingAdminList.propTypes = { | |||
| const OnboardingAdmin = () => { | |||
| const dispatch = useDispatch(); | |||
| const [eventLogModalParams, setEventLogModalParams] = useState(null); | |||
| const [showIncompleteOnly, setShowIncompleteOnly] = useState(false); // Add state to set the incomplete | |||
There was a problem hiding this comment.
nit: comment does not add any more info in this, I think. Might as well remove it. useState helps us know that this is a set for showing incomplete only.
| const filteredUsers = users.filter((user) => { | ||
| if (showIncompleteOnly) { | ||
| return !user.setupComplete; | ||
| } else { | ||
| return true; | ||
| } | ||
| }); |
There was a problem hiding this comment.
nit: could make it a bit more concise like this:```suggestion
users.filter((user) => (showIncompleteOnly ? !user.setupComplete : true));
|
Closing this branch. Creating a fresh branch off main and will try again. |
Overview
The onboarding Admin page has checkbox to filter users whose onboarding steps aren't complete. This makes it easier to view users who have Allocations and System Access steps not completed.
Related
Changes
Testing
users.jsxand add dummy users (https://gist.github.com/asimregmi/891566eab2ecf34b71d26f6d226be10c)OnboardingAdmin.jsxImport :
import dummyusers from './users'In line 243, remove { users }
In line 246:
const users = useSelector((state) => dummyusers)Another testing method: Add new entry to the props from the React dev tools, but might be inefficient
UI
Notes
Dummy Users file for testing
users.jsx