Task/WP-32--onboarding page filter show incomplete

[asimregmi]

Overview

The onboarding Admin page has checkbox to filter users whose onboarding steps aren't complete. This makes it easier to view users who have Allocations and System Access steps not completed.

Related

• WP-32

Changes

• Added Checkbox component
• Added new handler toggleShowIncomplete based on user interaction with checkbox
• Replaced users with filteredUsers

Testing

1. Create a new file users.jsx and add dummy users (https://gist.github.com/asimregmi/891566eab2ecf34b71d26f6d226be10c)
2. Add the following code to OnboardingAdmin.jsx
   Import : import dummyusers from './users'
   In line 243, remove { users }
   In line 246: const users = useSelector((state) => dummyusers)

Another testing method: Add new entry to the props from the React dev tools, but might be inefficient

UI

Notes

Dummy Users file for testing

users.jsx

[codecov]

Codecov Report

Merging #891 (373bc42) into main (1495914) will increase coverage by 0.00%.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   63.38%   63.38%           
=======================================
  Files         430      430           
  Lines       12292    12297    +5     
  Branches     2541     2542    +1     
=======================================
+ Hits         7791     7795    +4     
- Misses       4292     4293    +1     
  Partials      209      209           

Flag	Coverage Δ
javascript	69.74% <87.50%> (+<0.01%)	⬆️
unittests	56.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ient/src/components/Onboarding/OnboardingAdmin.jsx	73.25% <87.50%> (+0.41%)	⬆️

[asimregmi]

Chandra's comment on previous PR (closed)

comment does not add any more info in this, I think. Might as well remove it. useState helps us know that this is a set for showing incomplete only.

Chandra's comment on previous PR (closed)

could make it a bit more concise like this: suggestion
users.filter((user) => (showIncompleteOnly ? !user.setupComplete : true));

Fixed both of these.

[chandra-tacc]

LGTM!

[sophia-massie]

LGTM! Thanks