task/WP-65-DropdownViewFullPath - dropdown-menu css component #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## task/WP-65-DropdownViewFullPath #875 +/- ##
================================================================
Coverage 62.94% 62.94%
================================================================
Files 427 427
Lines 12219 12219
Branches 2513 2513
================================================================
Hits 7691 7691
Misses 4319 4319
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
wesleyboar
deleted the
task/WP-65-DropdownViewFullPath--dropdown-menu-css-component
branch
chandra-tacc
added a commit
that referenced
this pull request
Oct 27, 2023
* task/WP-65-DropdownViewFullPath * task/WP-65-DropdownViewFullPath-v2 * task/WP-65-DropdownViewFullPath-v3 * task/WP-65-DropdownViewFullPath-v4 * task/WP-65-DropdownViewFullPath-v5 * task/WP-65-DropdownViewFullPathv6 * task/WP-65-DropdownViewFullPath-v7 * task/WP-65-DropdownViewFullPath - dropdown-menu css component (#875) * task/WP-65-DropdownViewFullPath-v8 * task/WP-65-DropdownViewFullPath-v9 * task/WP-65-DropdownViewFullPath-v10 * task/WP-65-DropdownViewFullPath-v11 * task/WP-65-DropdownViewFullPath-v12 * task/WP-65-DropdownViewFullPath-v13 * task/WP-65-DropdownViewFullPath-v14 * task/WP-65-DropdownViewFullPath-v15 * Update client/src/components/DataFiles/DataFilesModals/DataFilesShowPathModal.jsx Co-authored-by: Sal Tijerina <[email protected]> * prettier fix --------- Co-authored-by: Taylor Grafft <[email protected]> Co-authored-by: Taylor Grafft <[email protected]> Co-authored-by: Sal Tijerina <[email protected]> Co-authored-by: Wesley B <[email protected]> Co-authored-by: Taylor Grafft <[email protected]> Co-authored-by: Taylor Grafft <[email protected]> Co-authored-by: Chandra Y <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not duplicate dropdown-menu styles (to resolve #866 (comment)).
Related
Changes
dropdown-menu.cssTesting
UI
Notes
There are some undesirable UI hacks and bugs. They may be fixed in separate PRs, because they seem to be caused by issues from target branch or
mainbranch. If actually this PR is causing new bugs, please report.Footnotes
Use of ID for this is not recommended, hence "temporary". See UI - CSS Style Guide - Specificity @ IDs in CSS. ↩