Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-299: Add Data Files button dropdown needs minor adjustment in alignment #878

Merged

Conversation

asimregmi
Copy link
Contributor

Overview

Minor adjust in alignment to address bug found in testing. Add Data Files dropdown isn't aligned properly.

Related

Changes

  • Added margin and switched the dropdown triangle to right

Testing

  1. Go to Data Files and click on "Add Data Files" button to check alignment

UI

image

Notes

@asimregmi asimregmi marked this pull request as ready for review October 9, 2023 14:51
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #878 (3d4840f) into main (b31a09d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   62.99%   62.99%           
=======================================
  Files         427      427           
  Lines       12197    12197           
  Branches     2506     2506           
=======================================
  Hits         7683     7683           
  Misses       4306     4306           
  Partials      208      208           
Flag Coverage Δ
javascript 68.67% <ø> (ø)
unittests 57.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjgrafft and @asimregmi,

Heads up, this change may have merge conflict with #875 in #866.

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandra-tacc chandra-tacc merged commit 982c7d6 into main Oct 9, 2023
6 checks passed
@chandra-tacc chandra-tacc deleted the Bug/WP-299--Add-Data-Files-dropdown-minor-alignment-adjust branch October 9, 2023 19:31
chandra-tacc added a commit that referenced this pull request Oct 9, 2023
…nment (#878)

* small UI change to align dropdown

* linting issues fixed

---------

Co-authored-by: Chandra Y <[email protected]>
chandra-tacc added a commit that referenced this pull request Oct 10, 2023
* WA-314: Input file fixes for hidden and fixed

* Task/WP-66: Refactored some variables and props to include proptypes (#876)

* Refactored some variables and props to include proptypes

* fixed linting errors

* WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878)

* small UI change to align dropdown

* linting issues fixed

---------

Co-authored-by: Chandra Y <[email protected]>

---------

Co-authored-by: Asim Regmi <[email protected]>
chandra-tacc added a commit that referenced this pull request Oct 10, 2023
* WA-314: Input file fixes for hidden and fixed

* Task/WP-66: Refactored some variables and props to include proptypes (#876)

* Refactored some variables and props to include proptypes

* fixed linting errors

* WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878)

* small UI change to align dropdown

* linting issues fixed

---------

Co-authored-by: Chandra Y <[email protected]>

---------

Co-authored-by: Asim Regmi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants