-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP-299: Add Data Files button dropdown needs minor adjustment in alignment #878
WP-299: Add Data Files button dropdown needs minor adjustment in alignment #878
Conversation
Codecov Report
@@ Coverage Diff @@
## main #878 +/- ##
=======================================
Coverage 62.99% 62.99%
=======================================
Files 427 427
Lines 12197 12197
Branches 2506 2506
=======================================
Hits 7683 7683
Misses 4306 4306
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjgrafft and @asimregmi,
Heads up, this change may have merge conflict with #875 in #866.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]>
* WA-314: Input file fixes for hidden and fixed * Task/WP-66: Refactored some variables and props to include proptypes (#876) * Refactored some variables and props to include proptypes * fixed linting errors * WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]> --------- Co-authored-by: Asim Regmi <[email protected]>
* WA-314: Input file fixes for hidden and fixed * Task/WP-66: Refactored some variables and props to include proptypes (#876) * Refactored some variables and props to include proptypes * fixed linting errors * WP-299: Add Data Files button dropdown needs minor adjustment in alignment (#878) * small UI change to align dropdown * linting issues fixed --------- Co-authored-by: Chandra Y <[email protected]> --------- Co-authored-by: Asim Regmi <[email protected]>
Overview
Minor adjust in alignment to address bug found in testing. Add Data Files dropdown isn't aligned properly.
Related
Changes
Testing
UI
Notes