Merge Bomb with MrBomb #3002
Merged
Merge Bomb with MrBomb #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
added
type:patch
involves:functionality
category:code
status:needs-review
tylerandari13
approved these changes
Jul 24, 2024
Frostwithasideofsalt
approved these changes
Jul 24, 2024
weluvgoatz
approved these changes
Jul 27, 2024
Vankata453
reviewed
Jul 28, 2024
|
@weluvgoatz I accidentally requested your review. |
Vankata453
reviewed
Aug 2, 2024
Co-authored-by: Vankata453 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR internally rewrites MrBomb to be more like GoldBomb. It doesn't add any considerable features.
It also removes lots of code duplication. The Bomb class is now obsolete.
As a result, the death script stays consistent between MrBomb and GoldBomb.
This PR also fixes a bug with gold bomb, in which getting out of the safe distance and going back in would freeze gold bomb in the same sprite action until another state change.