-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make minimum_travel_heading work #451
base: melodic-devel
Are you sure you want to change the base?
make minimum_travel_heading work #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I'm not sure this should be merged, but it is more technically correct. What's the issue you're running into this solves? I've typically found that updating a slam problem with pure rotation moves is a recipe for delocalization.
Hi @SteveMacenski |
Nice catch! I was facing some issues with this. Originally the minimum_travel_heading parameter existed but it was never used, which was misleading. Also, I think a separate parameter should not be necessary to disable this feature, since having it seems like the intended behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make minimum_travel_heading work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalize HeadingDifference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
normalize HeadingDifference
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points