Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make minimum_travel_heading work #451

Open
wants to merge 3 commits into
base: melodic-devel
Choose a base branch
from

Conversation

zengxiaolei
Copy link


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'm not sure this should be merged, but it is more technically correct. What's the issue you're running into this solves? I've typically found that updating a slam problem with pure rotation moves is a recipe for delocalization.

slam_toolbox/src/slam_toolbox_common.cpp Outdated Show resolved Hide resolved
slam_toolbox/src/slam_toolbox_common.cpp Outdated Show resolved Hide resolved
@Lrk114
Copy link

Lrk114 commented Mar 11, 2022

Hi @SteveMacenski
Many thanks for this package which is just amazing!
Would it be ok if we were to add an extra parameter to turn this feature on or off?
Indeed we might need this for some of our projects..
Many thanks in advance

@redvinaa
Copy link

Nice catch! I was facing some issues with this. Originally the minimum_travel_heading parameter existed but it was never used, which was misleading. Also, I think a separate parameter should not be necessary to disable this feature, since having it seems like the intended behavior.

@zengxiaolei zengxiaolei marked this pull request as draft May 30, 2023 07:55
Copy link
Author

@zengxiaolei zengxiaolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make minimum_travel_heading work

zengxiaolei

This comment was marked as duplicate.

zengxiaolei

This comment was marked as duplicate.

zengxiaolei

This comment was marked as duplicate.

Copy link
Author

@zengxiaolei zengxiaolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalize HeadingDifference

@zengxiaolei zengxiaolei marked this pull request as ready for review June 21, 2023 01:16
zengxiaolei

This comment was marked as duplicate.

Copy link
Author

@zengxiaolei zengxiaolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalize HeadingDifference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants