Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tables): use pseudo private custom properties #1204

Merged
merged 10 commits into from
Jan 5, 2023
Merged

refactor(tables): use pseudo private custom properties #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
685af24
refactor(tables): use pseudo private custom properties
dancormier Dec 5, 2022
9b2c38e
Merge branch 'develop' into dcormier/table-refactor
dancormier Dec 7, 2022
bb3116a
More PPCP refactoring
dancormier Dec 7, 2022
dff6dd1
Fix docs-specific .s-table td styling
dancormier Dec 7, 2022
823408b
Remove empty child element declarations
dancormier Dec 7, 2022
0b2e5e2
Cleanup
dancormier Dec 12, 2022
43dc24e
Fix custom property typo
dancormier Dec 13, 2022
7a8ae53
Fix .is-disabled tr background color override
dancormier Dec 13, 2022
48e0e29
Sort properties alphabetically
dancormier Dec 13, 2022
b8167bf
Renaming tables.less to table.less
dancormier Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions docs/assets/less/stacks-documentation.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,15 @@
// ----------------------------------------------------------------------------

.stacks-flex-example--item {
padding: var(--su8);
border: 1px solid var(--bc-medium);
background-color: var(--black-075);
font-family: var(--ff-mono);
font-size: var(--fs-caption);
color: var(--fc-dark);
&,
.s-table td& {
background-color: var(--black-075);
border: var(--su-static1) solid var(--bc-medium);
color: var(--fc-dark);
font-family: var(--ff-mono);
font-size: var(--fs-caption);
padding: var(--su8);
}
}

// ============================================================================
Expand Down
297 changes: 297 additions & 0 deletions lib/css/components/table.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,297 @@
.s-table-container {
overflow-x: auto;
@scrollbar-styles();
}

.s-table {
@ta-cell-border: var(--su-static1) solid var(--bc-medium);
@ta-columns: (100% / 12);

--_ta-tbody-tbody-bc: var(--bc-medium);
--_ta-tbody-tbody-bw: var(--su-static2);
--_ta-tbody-tr-even-bg: unset;
--_ta-td-bbw: 0;
--_ta-td-bc: var(--bc-medium);
--_ta-td-fs: unset;
--_ta-td-fw: unset;
--_ta-td-p: var(--su8);
--_ta-td-ta: left;
--_ta-td-va: middle;
--_ta-td-w: unset;
--_ta-thead-th-bg: var(--black-025);
--_ta-th-bbw: 0;
--_ta-th-bc: var(--bc-medium);
--_ta-th-fs: unset;
--_ta-th-p: var(--su8);
--_ta-th-ta: left;
--_ta-th-va: middle;
--_ta-th-w: unset;

// VARIANTS
&&__stripes {
--_ta-tbody-tr-even-bg: var(--black-025);
--_ta-thead-th-bg: var(--black-050);
}

// MODIFIERS
&.ta-center {
--_ta-td-ta: center;
--_ta-th-ta: center;
}

&.ta-left {
--_ta-td-ta: left;
--_ta-th-ta: left;
}

&.ta-justify {
--_ta-td-ta: justify;
--_ta-th-ta: justify;
}

&.ta-right {
--_ta-td-ta: right;
--_ta-th-ta: right;
}

&.va-bottom {
--_ta-td-va: bottom;
--_ta-th-va: bottom;
}

&.va-middle {
--_ta-td-va: middle;
--_ta-th-va: middle;
}

&.va-top {
--_ta-td-va: top;
--_ta-th-va: top;
}

&&__b0 {
--_ta-td-bc: transparent;
--_ta-th-bc: transparent;
--_ta-tbody-tbody-bc: transparent; // [1]
--_ta-tbody-tbody-bw: var(--su-static12); // [1]
--_ta-thead-th-bg: transparent;

thead th {
font-size: inherit;
text-transform: initial;
letter-spacing: initial;
}
}

&&__bx {
tr {
> *:not(:first-child) {
border-left-color: transparent;
}
> *:not(:last-child) {
border-right-color: transparent;
}
}
}

&&__bx-simple {
--_ta-thead-th-bg: transparent;
--_ta-foot-td-bc: transparent;
--_ta-foot-th-bc: transparent;

td,
th {
border-left-color: transparent;
border-right-color: transparent;
}

tbody tr {
&:first-of-type th,
&:first-of-type td {
border-top-color: transparent;
}
&:last-of-type th,
&:last-of-type td {
border-bottom-color: transparent;
}
}

thead th {
border-top-color: transparent;
border-bottom-color: var(--bc-darker);
font-size: inherit;
text-transform: initial;
letter-spacing: initial;
}
}

&&__sortable {
thead th {
a { // If an anchor is used, it should appear like a normal header
color: inherit;
}

&.is-sorted { // Selected state
color: var(--black-900);
}

color: var(--fc-light);
cursor: pointer;
}
}

// Sizes
&&__sm {
--_ta-td-p: var(--su4);
--_ta-th-p: var(--su4);
}

&&__lg {
--_ta-td-p: var(--su12);
--_ta-th-p: var(--su12);
}

// CHILD ELEMENTS
& &--cell {
.generate-cell-widths-classes(@n, @i: 1) when (@i =< @n) {
&@{i} { // generates iterated cell classes
@ta-cell-w: @ta-columns * @i;
--_ta-td-w: @ta-cell-w;
--_ta-th-w: @ta-cell-w;
}
.generate-cell-widths-classes(@n, (@i + 1));
}

.generate-cell-widths-classes(12);
}

& &--totals {
--_ta-td-fs: var(--fs-subheading);
--_ta-td-pt: var(--su12);
--_ta-td-fw: bold;
--_ta-th-fs: var(--fs-subheading);
--_ta-th-pt: var(--su12);
}

tbody {
+ tbody { // If two table bodies are next to each other, visually separate them
border-top: var(--_ta-tbody-tbody-bw) solid var(--_ta-tbody-tbody-bc);
}

th {
font-weight: normal;
}

tr {
&:nth-child(2n) {
background-color: var(--_ta-tbody-tr-even-bg);
}
}
}

td {
.s-checkbox {
display: block;
}

&.s-table--bulk {
--_ta-td-w: calc(var(--su32) - var(--su2)); // 30px;
}

&.s-table--progress {
--_ta-td-ta: right;
--_ta-td-brw: 0;
}

&.s-table--progress-bar {
--_ta-td-blw: 0;
--_ta-td-pl: 0;
--_ta-td-w: 120px;
}

border: var(--su-static1) solid var(--_ta-td-bc);
border-bottom-width: var(--_ta-td-bbw, var(--su-static1));
border-left-width: var(--_ta-td-blw, var(--su-static1));
border-right-width: var(--_ta-td-brw, var(--su-static1));
border-top-width: var(--_ta-td-btw, var(--su-static1));
font-size: var(--_ta-td-fs);
font-weight: var(--_ta-td-fw);
padding: var(--_ta-td-p);
padding-left: var(--_ta-td-pl, var(--_ta-td-p));
padding-top: var(--_ta-td-pt, var(--_ta-td-p));
text-align: var(--_ta-td-ta);
vertical-align: var(--_ta-td-va);
width: var(--_ta-td-w);

color: var(--fc-medium);
}

tfoot {
td {
border-bottom-color: var(--_ta-foot-td-bc, var(--_ta-td-bc));
}

th {
border-bottom-color: var(--_ta-foot-th-bc, var(--_ta-td-bc));
}
}

th {
.s-checkbox {
display: block;
}

&.s-table--bulk {
--_ta-th-w: calc(var(--su32) - var(--su2)); // 30px;
}

border: var(--su-static1) solid var(--_ta-th-bc);
border-width: var(--su-static1) var(--su-static1) var(--_ta-th-bbw);
font-size: var(--_ta-th-fs);
padding: var(--_ta-th-p);
padding-top: var(--_ta-th-pt, var(--_ta-th-p));
text-align: var(--_ta-th-ta);
vertical-align: var(--_ta-th-va);
width: var(--_ta-th-w);

color: var(--fc-dark);
font-weight: bold;
}

thead {
th {
background-color: var(--_ta-thead-th-bg);

line-height: var(--lh-sm);
vertical-align: bottom;
white-space: nowrap;
}
}

tr {
&:last-of-type {
--_ta-td-bbw: var(--su-static1);
--_ta-th-bbw: var(--su-static1);
}

&.is-disabled {
background-color: var(--black-025);
--_ta-tbody-tr-even-bg: var(--black-025);

th:not(.is-enabled),
td:not(.is-enabled) {
opacity: calc(var(--_o-disabled) * 0.6); // 0.5 * 0.6 = 0.3
}
}
}

border-collapse: collapse;
border-spacing: 0;
display: table;
font-size: var(--fs-body1);
max-width: 100%;
width: 100%;
}

// [1] This makes the border transparent, so we need to use whitespace
// to achieve the same effect a 2px gray border achieves.
Loading