refactor(tables): use pseudo private custom properties #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @dancormier I see that you are refactoring table component and there is Issue that I tried to fix. So maybe there is chance now for merging my PR, if you feel it make sense. |
giamir
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Great work @dancormier!
There are a couple of small fixes to address which I have highlighted in my comments.
Apart from that this looks good to me. I don't think I need to re-review after you have applied the changes - feel free to go ahead and merge. 🙂
|
Core's been updated. Time to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
.s-tablecomponent styling to use pseudo-private custom properties. With this refactor, I didn't flatten the cascade for variants/modifiers entirely as I have with many other refactors. Tables include some very targeted styles (targetingfirst/last/nthof nested elements) that would've made a complete* flattening more confusing and hard to maintain than the alternative.* "complete" as consistent, not as in total or done.