fix: Fix incorrect ratchet behavior on relative source path #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 93.37% 93.40% +0.03%
==========================================
Files 6 6
Lines 181 182 +1
Branches 18 18
==========================================
+ Hits 169 170 +1
Misses 11 11
Partials 1 1
Continue to review full report at Codecov.
|
algomaster99
requested changes
May 9, 2021
|
@algomaster99 Yep :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47
When the source path (i.e. the one given as input to
runSorald) is relative, the matching between violation specifiers and changed code doesn't work (as the diff filepaths are absolute).This PR fixes this by resolving the absolute path to the source in
runSorald.Note that there's now quite a lot of repetition in the
main.test.tstest module. I intend to fix that with a separate refactoring, see #48.