-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add job for sorald-buildbreaker #3912
chore: Add job for sorald-buildbreaker #3912
Conversation
Current failure is a bug in sorald-buildbreaker, see SpoonLabs/sorald-buildbreaker#46 |
Curiously, dead stores are not detected in constructors. Bug in Sonar?
The new violation is found by Sonar, but there's obviously some problem with the ratchet as buildbreaker does not try to repair it. Back to the drawing board! Edit: It was a problem with relative source paths, see SpoonLabs/sorald-buildbreaker#49 |
Ah, it finally works, the newly introduced rule violation is detected: https://github.com/INRIA/spoon/pull/3912/checks?check_run_id=2543019363#step:3:123 |
Excellent, thanks a lot @slarse |
Fix #3788
This PR adds a workflow job that runs https://github.com/spoonlabs/sorald-buildbreaker on Spoon, and fails the build if the changed lines (relative to master) contains any repairable violations. Here's an example of where it finds a violation in the diff: https://github.com/INRIA/spoon/pull/3912/checks?check_run_id=2543019363#step:3:123. Note that the final commit in this PR, which just removes the artificial rule violation, causes the build to go green!
Currently, it's a separate job, but once we deem buildbreaker to be stable enough we can simply incorporate it into the
extras
job by adding this step:Next steps are to improve the stability of buildbreaker, and also identify what else we want buildbreaker to do. How should it present rule violations (current presentation is cryptic to the uninitiated, to say the least)? Should it propose a patch to fix the violation? Etc, etc.