Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(openchallenges): improve organization service exception unit test coverage to 100% #2348

Merged
merged 34 commits into from
Dec 4, 2023
Merged

test(openchallenges): improve organization service exception unit test coverage to 100% #2348

merged 34 commits into from
Dec 4, 2023

Conversation

mdsage1
Copy link
Contributor

@mdsage1 mdsage1 commented Nov 9, 2023 •
edited
Loading

Description

Unit test coverage has been increased to 100% for exception module.

Related Issue

#2063
#1528

Changelog

See files Changed section

There are now unit tests for every aspect of exception providing 100% coverage.

image

Preview

Overall coverage has increased to 15%, from 3%, for organization service.
image

@mdsage1 mdsage1 self-assigned this Nov 9, 2023
@mdsage1 mdsage1 changed the title (feat) improve exception unit test coverage to 100% (feat) improve exception unit test coverage to 100% for organization-service Nov 9, 2023
@mdsage1 mdsage1 changed the title (feat) improve exception unit test coverage to 100% for organization-service (feat) improve exception unit test coverage to 100% for organization service Nov 9, 2023
@mdsage1 mdsage1 mentioned this pull request Nov 9, 2023
Closed
1 task
@mdsage1 mdsage1 changed the title (feat) improve exception unit test coverage to 100% for organization service (feat) improve organization service exception unit test coverage to 100% Nov 9, 2023
@mdsage1 mdsage1 changed the title (feat) improve organization service exception unit test coverage to 100% [feat] improve organization service exception unit test coverage to 100% Nov 9, 2023
@mdsage1 mdsage1 changed the title [feat] improve organization service exception unit test coverage to 100% feat(openchallenges): improve organization service exception unit test coverage to 100% Nov 9, 2023
@mdsage1 mdsage1 marked this pull request as ready for review November 9, 2023 22:48
@tschaffter
Copy link
Member

tschaffter commented Nov 9, 2023 •
edited
Loading

@mdsage1 About this PR title: it should use the scope test instead of feat. I should have used this scope in my previous PR myself.

@mdsage1 mdsage1 changed the title feat(openchallenges): improve organization service exception unit test coverage to 100% scope(openchallenges): improve organization service exception unit test coverage to 100% Nov 9, 2023
@mdsage1
Copy link
Contributor Author

mdsage1 commented Nov 9, 2023

@tschaffter Changed feat to scope in the title

@mdsage1 mdsage1 changed the title scope(openchallenges): improve organization service exception unit test coverage to 100% test(openchallenges): improve organization service exception unit test coverage to 100% Nov 9, 2023
@mdsage1 @tschaffter
Update apps/openchallenges/organization-service/src/test/java/org/sag…
fab8628 
…ebionetworks/openchallenges/organization/service/exception/GlobalExceptionHandlerTest.java

Co-authored-by: Thomas Schaffter <[email protected]>
@mdsage1 mdsage1 marked this pull request as draft November 10, 2023 18:44
@mdsage1 mdsage1 marked this pull request as ready for review November 10, 2023 18:55
@mdsage1 mdsage1 marked this pull request as draft November 10, 2023 21:58
@mdsage1
Copy link
Contributor Author

mdsage1 commented Nov 10, 2023

BadRequestExceptionTest has been updated to condense tests

@mdsage1 mdsage1 marked this pull request as ready for review November 29, 2023 18:50
@mdsage1 mdsage1 marked this pull request as draft November 29, 2023 18:50
@mdsage1
Copy link
Contributor Author

mdsage1 commented Nov 29, 2023

Changed 'message' variable name back to 'detail' in OrganizationAlreadyExistsExceptionTest.java

@mdsage1 mdsage1 marked this pull request as ready for review November 29, 2023 19:21
@tschaffter tschaffter merged commit 3355901 into Sage-Bionetworks:main Dec 4, 2023
6 checks passed
This was referenced Dec 5, 2023
Merged
Merged
@mdsage1 mdsage1 deleted the org_srv_unit_tst_excptns branch February 16, 2024 16:49
@mdsage1 mdsage1 mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tschaffter tschaffter tschaffter approved these changes

@rrchai rrchai Awaiting requested review from rrchai rrchai is a code owner

@vpchung vpchung Awaiting requested review from vpchung

Assignees

@mdsage1 mdsage1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdsage1 @tschaffter