-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(openchallenges): improve organization service model entity unit test coverage #2389
test(openchallenges): improve organization service model entity unit test coverage #2389
Conversation
@tschaffter Do you feel this covers #1528? Or were you thinking about another class when creating this? This is intended to be reviewed after #2388 but were created during the same week. |
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
Changes implemented:
|
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
Organization entity properties, login and email, were removed during PR #2399 which caused the OrganizationEntityTest.java unit tests to fail. Removed the unit tests related to the Organization Entity login and email properties. Sonar coverage was reduced to 48%. |
...sagebionetworks/openchallenges/organization/service/model/entity/OrganizationEntityTest.java
Outdated
Show resolved
Hide resolved
@tschaffter This is ready for you to review. I made the changes you asked for:
|
Update 2024-02-13I tried to push changes to this PR but git didn't offer me this option unlike when attempting to push to Verena's and Rong's PR. I wanted to delete the file that only include commented content. I will now merge this PR and make the change later. |
Description
Sonar unit organization service test coverage has been increased to 45% for model/entity package by writing unit tests for a single class, OrganizationEntity.
Related Issue
#2063
#1528
#2348
#2388
Changelog
See
files Changed
sectionThese changes have increased the Sonar coverage from the 15% achieved with the exception unit test PR #2348 (9.45% overall). These tests were written last week and debugged this week. The PR has been released after the approval of the exception unit test PR on 2023-12-04.
Preview
Overall sonar coverage has increased to 50%, from 0%, for organization service model entity.
The Sonar coverage increase for model/mapper:
The goal was to get organization-service > 30% and I will confirm this once the PR has been merged. Given that the Sonar coverage calculation is 15% higher than the intended coverage it's possible that the Code Quality Dashboard will reflect 30% code coverage with the updates made to this class.