generated from SU-SWS/stanford_starter
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHEMH-83 | @jdwjdwjdw | Structure and style News node page #67
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d49e0ed
Update news node template
jdwjdwjdw 879b630
Update News node page
jdwjdwjdw a17aec6
Update news node page
jdwjdwjdw a206de5
Update news more-link to gradient button
jdwjdwjdw 607675a
Update news node
jdwjdwjdw 357caa0
Update news node
jdwjdwjdw a4f997e
Merge branch '2.x' into CHEMH-83--news-node
jdwjdwjdw 16ae08c
Update dist, remove unnecessary code
jdwjdwjdw 2f34d8c
Update news header and topics
jdwjdwjdw 8c4f5e5
Merge branch '2.x' into CHEMH-83--news-node
jdwjdwjdw bea0ea1
Update dist, button fixup, news node spacing fixups
jdwjdwjdw 8bafa86
Remove commented out code
jdwjdwjdw afe9e5b
Remove unnecessary code
jdwjdwjdw 7432ca7
Fixup past event color
jdwjdwjdw 5740b59
Fixup for past event with no event types
jdwjdwjdw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| {# Create classes array. The 'node' class is required for contextual edit links. #} | ||
| {% set node_classes = ['node'] %} | ||
| {% set node_classes = node_classes|merge([ | ||
| node.type ? node.type.entity.label|clean_class, | ||
| view_mode ? 'node--layout-' ~ view_mode|clean_class | ||
| ]) %} | ||
| {% set title_classes = [ node.bundle|clean_class ~ '__title'] %} | ||
| {% set attributes = attributes.addClass(node_classes) %} | ||
| {% set attributes = attributes.removeAttribute('role') %} | ||
|
|
||
| {# Template Paths #} | ||
| {%- if template_alert is empty -%} | ||
| {%- set template_alert = "@basic-dist/decanter/components/alert/alert.twig" -%} | ||
| {%- endif -%} | ||
| {# End Template Paths #} | ||
|
|
||
| {% if page %} | ||
| {# Node as a page should be a section. #} | ||
| <section{{ attributes }}> | ||
| {# Unpublished Warning. #} | ||
| {%- if not node.published -%} | ||
|
|
||
| {% set message = "This page is currently unpublished and not visible to the public." %} | ||
| {% if node.publish_on and not node.publish_on.isEmpty %} | ||
| {% set message =message ~ " The page is also scheduled to publish in the future." %} | ||
| {% endif %} | ||
|
|
||
| {%- set data = { | ||
| 'attributes': create_attribute({'class': 'su-alert su-alert--warning'}), | ||
| 'alert_text': message|t, | ||
| } -%} | ||
| {%- include template_alert with data only -%} | ||
| {%- endif -%} | ||
|
|
||
| {# Node in a list should be it's own article. #} | ||
| {% else %} | ||
| <article{{ attributes }}> | ||
| {% endif %} | ||
| {% if title_prefix or title_suffix or display_submitted or unpublished or page is empty and label %} | ||
| <header> | ||
|
|
||
| {# Title Prefix #} | ||
| {{ title_prefix }} | ||
|
|
||
| {%- if not page and label -%} | ||
| <h2{{ title_attributes.addClass(title_classes) }}> | ||
| <a href="{{ url }}" rel="bookmark">{{ label }}</a> | ||
| </h2> | ||
| {%- endif -%} | ||
|
|
||
| {# Title Suffix #} | ||
| {{ title_suffix }} | ||
|
|
||
| {# Display Submitted #} | ||
| {%- if display_submitted -%} | ||
| <div class="submitted"> | ||
| {{ author_picture }} | ||
| {% trans %}Submitted by {{ author_name }} on {{ date }}{% endtrans %} | ||
| {{ metadata }} | ||
| </div> | ||
| {%- endif -%} | ||
| </header> | ||
| {%- endif -%} | ||
|
|
||
|
|
||
| {# Main content container. #} | ||
| <div{{ content_attributes.addClass('content') }}> | ||
| <div class="header-spacer"></div> | ||
| <div class="layout--section-news-header"> | ||
| {{ content|without('links') }} | ||
| </div> | ||
| </div><!-- /.content --> | ||
|
|
||
| {%- if content.links -%} | ||
| <div class="links"> | ||
| {{ content.links }} | ||
| </div><!-- /.links --> | ||
| {%- endif -%} | ||
|
|
||
| {% if page %} | ||
| </section><!-- /.node as page --> | ||
| {% else %} | ||
| </article><!-- /.node as a list --> | ||
| {% endif %} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdwjdwjdw Can we discuss these media queries? When I'm looking at the results in the browser, only the one on line 138 is in effect, all the later ones are overridden.