-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHEMH-83 | @jdwjdwjdw | Structure and style News node page #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jenbreese! I fixed that up and addressed some other spacing issues in situations where there isn't a dek / a top banner is/isn't used. Should be good to re-review now. |
|
||
.main-region { | ||
@include grid-media-min('sm') { | ||
-webkit-box-flex: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdwjdwjdw I'm don't think you need to have the -webkit prefixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
@@ -136,36 +136,26 @@ | |||
|
|||
.main-region { | |||
@include grid-media-min('sm') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdwjdwjdw Can we discuss these media queries? When I'm looking at the results in the browser, only the one on line 138 is in effect, all the later ones are overridden.
READY FOR REVIEW
Summary
Review By (Date)
Urgency
Review Tasks
Setup tasks and/or behavior to test
See All News
button at the bottom of the news node page looks correct and fixes the issue mentioned in CHEMH-242Associated Issues and/or People