Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] Instance version checks for Annex.C3 file export; fixes #281 #282

Merged
merged 3 commits into from
Dec 8, 2023
Merged

[ADD] Instance version checks for Annex.C3 file export; fixes #281 #282

merged 3 commits into from
Dec 8, 2023

Conversation

lxatstariongroup
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-SDK code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

[ADD] Instance version checks for Annex.C3 file export

@lxatstariongroup lxatstariongroup self-assigned this Nov 29, 2023
@lxatstariongroup lxatstariongroup linked an issue Nov 29, 2023 that may be closed by this pull request
Implement instance version checks in Annex.C3 #281
Closed
3 tasks
samatstariongroup
samatstariongroup approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@samatstariongroup samatstariongroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just make sure to bump version numbers when making new sdk release

CDP4Common/CDP4Common.csproj Outdated Show resolved Hide resolved
@lxatstariongroup lxatstariongroup force-pushed the feat/gh281-implement-AnnexC3-instance-version-checks branch from 299e7a4 to 11f12af Compare December 8, 2023 09:41
@lxatstariongroup lxatstariongroup merged commit f4231c2 into development Dec 8, 2023
2 of 4 checks passed
@lxatstariongroup lxatstariongroup deleted the feat/gh281-implement-AnnexC3-instance-version-checks branch December 8, 2023 13:18
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
4.6% 4.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineatstariongroup antoineatstariongroup antoineatstariongroup approved these changes

@samatstariongroup samatstariongroup samatstariongroup approved these changes

Assignees

@lxatstariongroup lxatstariongroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement instance version checks in Annex.C3
3 participants
@lxatstariongroup @samatstariongroup @antoineatstariongroup