Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement instance version checks in Annex.C3 #281

Closed
3 tasks done
lxatstariongroup opened this issue Nov 29, 2023 · 0 comments · Fixed by #282
Closed
3 tasks done

Implement instance version checks in Annex.C3 #281

lxatstariongroup opened this issue Nov 29, 2023 · 0 comments · Fixed by #282
Assignees
Milestone

Comments

@lxatstariongroup
Copy link
Contributor

lxatstariongroup commented Nov 29, 2023

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the COMET-SDK
  • I have searched open and closed issues to ensure it has not already been reported

Description

Implement instance version checks in Annex.C3:
Case: A Parameter references a SampledFunctionParameterType (model version 1.3) and an Annex.C3 export is created for model version 1.0.0
Currently the SampledFunctionParameterType itself is filtered out because of the fact that the class has a version attribute stating it is a 1.3.0 model version class. SampledFunctionParameterType is therefore not in the export file. The Parameter however, is still there and it references the Iid of the SampledFunctionParameterType which is not in the file. When trying to import the file, the import fails as the foreign key constraint from ParameterBase to ParameterType (SampledFunctionParameterType is filtered out) is failing.

Make sure that:

  • These references are updated, so no foreign key constraint errors anymore.
  • If the result of removing the reference is an incompatible model, remove the referencing object from the model and thrown a ModelErrorException if that still leads to an inconsistent model.
@lxatstariongroup lxatstariongroup added this to the sprint 90 milestone Nov 29, 2023
@lxatstariongroup lxatstariongroup self-assigned this Nov 29, 2023
lxatstariongroup added a commit that referenced this issue Dec 8, 2023
* [ADD] Instance version checks for Annex.C3 file export
* Add reference to github ticket
* Version bump
@samatstariongroup samatstariongroup moved this to Done in COMET-CE Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
1 participant