Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Start queue worker with service start instead of first call #34923

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jan 9, 2025

Backport of #34903

@dionisio-bot dionisio-bot bot requested a review from KevLehman January 9, 2025 18:34
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 3a08362

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/omnichannel-services Patch
@rocket.chat/meteor Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/queue-worker Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Jan 9, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.1.1, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR Preview Action v1.5.0
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34923/
on branch gh-pages at 2025-01-09 18:46 UTC

@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Jan 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.1.1@612ce30). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.1.1   #34923   +/-   ##
================================================
  Coverage                 ?   59.32%           
================================================
  Files                    ?     2818           
  Lines                    ?    67858           
  Branches                 ?    15078           
================================================
  Hits                     ?    40257           
  Misses                   ?    24766           
  Partials                 ?     2835           
Flag Coverage Δ
unit 75.80% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 51d0357 into release-7.1.1 Jan 10, 2025
53 of 54 checks passed
@kodiakhq kodiakhq bot deleted the backport-7.1.1-34903 branch January 10, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants