-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Start queue worker with service start instead of first call #34903
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7ffcb34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34903 +/- ##
=========================================
Coverage 59.13% 59.13%
=========================================
Files 2819 2819
Lines 67957 67449 -508
Branches 15138 15029 -109
=========================================
- Hits 40188 39889 -299
+ Misses 24935 24745 -190
+ Partials 2834 2815 -19
Flags with carried forward coverage won't be shown. Click here to find out more. |
/patch |
after that just run |
/patch |
Pull request #34912 added to Project: "undefined" |
/patch |
Pull request #34918 added to Project: "Patch 7.2.1" |
/backport 7.1.1 |
Pull request #34923 added to Project: "Patch 7.1.1" |
/backport 7.0.5 |
Sorry, I couldn't do that backport because of conflicts. Could you please solve them? you can do so by running the following commands:
after that just run |
/backport 7.0.5 |
Pull request #34924 added to Project: "Patch 7.0.5" |
Proposed changes (including videos or screenshots)
Fixes a behavior when running microservices that caused queue worker to process just the first 60 seconds of request.
This was due to a mistakenly bound context. Queue Worker was changed to start doing work only after it received the first request.
However, with the introduction of ASL and actual context on calls, the worker registration was absorbing the context of the call that created them, causing service calls happening inside the callbacks to fail because of a timeout.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-721
Steps to test or reproduce
Further comments