Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Start queue worker with service start instead of first call #34903

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jan 7, 2025

Proposed changes (including videos or screenshots)

Fixes a behavior when running microservices that caused queue worker to process just the first 60 seconds of request.

This was due to a mistakenly bound context. Queue Worker was changed to start doing work only after it received the first request.

However, with the introduction of ASL and actual context on calls, the worker registration was absorbing the context of the call that created them, causing service calls happening inside the callbacks to fail because of a timeout.

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-721

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jan 7, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 7ffcb34

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/omnichannel-services Patch
@rocket.chat/meteor Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/queue-worker Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/presence-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman changed the title disconnect context fix: Start queue worker with service start instead of first call Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

PR Preview Action v1.5.0
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34903/
on branch gh-pages at 2025-01-08 20:04 UTC

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.13%. Comparing base (c7be829) to head (7ffcb34).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #34903    +/-   ##
=========================================
  Coverage    59.13%   59.13%            
=========================================
  Files         2819     2819            
  Lines        67957    67449   -508     
  Branches     15138    15029   -109     
=========================================
- Hits         40188    39889   -299     
+ Misses       24935    24745   -190     
+ Partials      2834     2815    -19     
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added this to the 7.3.0 milestone Jan 8, 2025
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jan 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 8, 2025
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 8, 2025
@sampaiodiego sampaiodiego added the stat: ready to merge PR tested and approved waiting for merge label Jan 8, 2025
@kodiakhq kodiakhq bot merged commit 4aa95b6 into develop Jan 8, 2025
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/pdf-transcript-ctx branch January 8, 2025 20:41
@sampaiodiego
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jan 8, 2025

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:
git fetch
git checkout backport-6.10.11-34903
git cherry-pick 4aa95b61edaf6ce4fe0c5bdbc3d0157bf3d6794b
// solve the conflict
git push

after that just run /patch again

@sampaiodiego
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jan 8, 2025

Pull request #34912 added to Project: "undefined"

@sampaiodiego
Copy link
Member

/patch

Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025

Pull request #34918 added to Project: "Patch 7.2.1"

@sampaiodiego
Copy link
Member

/backport 7.1.1

Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025

Pull request #34923 added to Project: "Patch 7.1.1"

@sampaiodiego
Copy link
Member

/backport 7.0.5

Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.0.5-34903
git cherry-pick 4aa95b61edaf6ce4fe0c5bdbc3d0157bf3d6794b
// solve the conflict
git push

after that just run /backport 7.0.5 again

@sampaiodiego
Copy link
Member

/backport 7.0.5

Copy link
Contributor

dionisio-bot bot commented Jan 9, 2025

Pull request #34924 added to Project: "Patch 7.0.5"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants