Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings about default parameter values changes #997

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Add warnings about default parameter values changes #997

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5e238f
Add warning about `call_services_in_new_thread` parameter
bjsowa Jan 23, 2025
3dafd53
Fix flake8 error
bjsowa Jan 23, 2025
9bbf376
Add warning about `send_action_goals_in_new_thread` parameter
bjsowa Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions rosbridge_server/scripts/rosbridge_websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,22 @@ def check_deprecated_parameters(self):
"will be updated to 5.0 seconds."
)

if RosbridgeWebSocket.call_services_in_new_thread is False:
self.get_logger().warn(
"The 'call_services_in_new_thread' parameter is currently set to False, "
"which means service calls will block the main thread. "
"Please note that in the Jazzy and later releases, the default value for this parameter "
"will be updated to True."
)

if RosbridgeWebSocket.send_action_goals_in_new_thread is False:
self.get_logger().warn(
"The 'send_action_goals_in_new_thread' parameter is currently set to False, "
"which means sending action goals will block the main thread. "
"Please note that in the Jazzy and later releases, the default value for this parameter "
"will be updated to True."
)


def main(args=None):
if args is None:
Expand Down