Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings about default parameter values changes #997

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

bjsowa
Copy link
Collaborator

@bjsowa bjsowa commented Jan 23, 2025

Public API Changes
None

Description
Related to #996

@bjsowa bjsowa requested a review from sea-bass January 23, 2025 15:40
Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on doing the same for actions / renaming the PR

@bjsowa bjsowa changed the title Add warning about call_services_in_new_thread parameter Add warnings about default parameter values changes Jan 23, 2025
@bjsowa bjsowa requested a review from sea-bass January 23, 2025 16:28
@bjsowa
Copy link
Collaborator Author

bjsowa commented Jan 23, 2025

@sea-bass Not sure if this is excessive spam of annoying warnings or not.

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine! Deprecations are best handled when the warnings are annoying

@bjsowa bjsowa merged commit 8cd4208 into humble Jan 24, 2025
4 checks passed
@bjsowa bjsowa deleted the chore/service-threads-warning branch January 24, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants