Fixed compiler warnings #2313

rociopv06 · 2024-12-09T00:54:10Z

Fixed the warnings all around the code base. Hopefully this will facilitate debugging and should not affect any previous performance.

… minor fixes in test classes (making variables [[maybe_unused]] & fixing a comment

…/robocup-software into compiler-warning-fix adding all current changes for compiler warning fix

update with most current ros2 branch

automated style fixes Co-authored-by: jonagil1661 <[email protected]>

sid-parikh

Oops, my bad. i started this review weeks ago and never finished it.

sid-parikh · 2025-01-23T01:14:53Z

robocup-software

please uncommit this. you have cloned our repo inside itself.

try rm -rf robocup-software (make sure you are inside the outer robocup-software first!)

sid-parikh · 2025-01-23T01:17:21Z

soccer/src/rj_vision_filter/camera/camera.cpp

@@ -163,7 +163,7 @@ void Camera::update_balls_mhkf(RJ::Time calc_time, const std::vector<CameraBall>
        const CameraBall& camera_ball = ball_list.at(i);
        bool was_used = used_camera_ball.at(i);

-        if (!was_used && kalman_ball_list_.size() < PARAM_max_num_kalman_balls) {
+        if (!was_used && (int64_t) kalman_ball_list_.size() < PARAM_max_num_kalman_balls) {


Suggested change

if (!was_used && (int64_t) kalman_ball_list_.size() < PARAM_max_num_kalman_balls) {

if (!was_used && static_cast<int64_t>(kalman_ball_list_.size()) < PARAM_max_num_kalman_balls) {

or you could maybe do

Suggested change

if (!was_used && (int64_t) kalman_ball_list_.size() < PARAM_max_num_kalman_balls) {

if (!was_used && static_cast<decltype(PARAM_max_num_kalman_balls)>(kalman_ball_list_.size()) < PARAM_max_num_kalman_balls) {

i'm not sure the best practice, anything is fine really, but no C-style casts please.

sid-parikh · 2025-01-23T01:18:03Z

soccer/src/soccer/control/trapezoidal_motion_test.cpp

-    double max_acc = 1;
-    double start_speed = 0.901393;
-    double final_speed = 0;
+    [[maybe_unused]] double pos_out = 1.11101;


if these are unused can we just delete them?

sid-parikh · 2025-01-23T01:18:24Z

soccer/src/soccer/debug_drawer.hpp

@@ -112,7 +112,7 @@ class DebugDrawer {
    /// Debug layers in order by ID
    QStringList debug_layers_;

-    Context* context_;
+    [[maybe_unused]] Context* context_;


this seems really sus...

sid-parikh · 2025-01-23T01:19:45Z

soccer/src/soccer/planning/planner/path_target_path_planner.cpp

@@ -30,7 +30,7 @@ Trajectory PathTargetPathPlanner::plan(const PlanRequest& request) {
    }

    LinearMotionInstant target_instant = command.target;
-    Point goal_point = target_instant.position;
+    [[maybe_unused]] Point goal_point = target_instant.position;


again, local vars that are unused should just be deleted.

sid-parikh · 2025-03-12T23:28:30Z

soccer/src/soccer/strategy/agent/position/robot_factory_position.cpp

@@ -197,7 +197,7 @@ void RobotFactoryPosition::start_kicker_picker() {
 bool RobotFactoryPosition::have_all_kicker_responses() {
    int num_alive = std::count(alive_robots_.begin(), alive_robots_.end(), true);

-    return kicker_distances_.size() == num_alive - 1;  // Don't expect the goalie to respond
+    return (int)kicker_distances_.size() == num_alive - 1;  // Don't expect the goalie to respond


static cast

sid-parikh · 2025-03-12T23:32:26Z

soccer/src/soccer/strategy/agent/position/zoner.hpp

@@ -30,8 +30,24 @@ class Zoner : public Position {
    ~Zoner() override = default;
    Zoner(const Position& other);
    Zoner(Zoner&& other) = default;
-    Zoner& operator=(const Zoner& other) = default;
-    Zoner& operator=(Zoner&& other) = default;
+    // Zoner& operator=(const Zoner& other) = default;


you're actually right here, this is pretty frustrating; it's why const members are very discouraged. however, i'm scared to write these explicitly because we'd have to maintain them if we ever add members. i would say it's better to either explicitly = delete these operators (we rarely would have a use for them anyway) or simply remove the const qualifiaction from the member (i don't even see it, but i have a hunch it could be robot_id in the super class)

sid-parikh · 2025-03-12T23:32:54Z

soccer/src/soccer/ui/main_window.cpp

@@ -341,7 +341,7 @@ void MainWindow::updateViews() {
            QString("Log: %1 kiB").arg(QString::number((context_->logs.size_bytes + 512) / 1024)));
    }

-    auto value = _ui.logHistoryLocation->value();
+    [[maybe_unused]] auto value = _ui.logHistoryLocation->value();


again [[maybe_unused]] local variable declarations seems like an anti-pattern, probably just remove them?

sid-parikh · 2025-03-12T23:33:15Z

soccer/testing/rj_vision_filter/kalman_robot_test.cpp

@@ -95,9 +95,9 @@ TEST(KalmanRobot, predict) {
    kb.predict(t);

    rj_geometry::Point rp2 = kb.get_pos();
-    rj_geometry::Point rv2 = kb.get_vel();
+    [[maybe_unused]] rj_geometry::Point rv2 = kb.get_vel();


same as above

sid-parikh · 2025-03-12T23:33:30Z

soccer/src/soccer/ui/referee_tab.hpp

@@ -4,7 +4,7 @@
 #include "ui_RefereeTab.h"

 class RefereeTab : public QWidget {
-    Q_OBJECT;


thanks. (but wow i hate QT)

rociopv06 and others added 9 commits November 12, 2024 21:02

Fixed warning in position waller.cpp by casting num_wallers into int,…

4404b28

… minor fixes in test classes (making variables [[maybe_unused]] & fixing a comment

added static_cast<int>

16b706c

waller compiler warning fix

e43ec11

Merge branch 'compiler-warning-fix' of https://github.com/RoboJackets…

96e41b7

…/robocup-software into compiler-warning-fix adding all current changes for compiler warning fix

Fixed unused parameter warnings

8dee746

Fixed most of compiler warnings

c2eec16

Fixed most of compiler warnings

7152f74

fixed more compiler warnings

d69ce62

fixed more compiler warnings

6573f9f

github-actions bot mentioned this pull request Dec 9, 2024

Fix Code Style On compiler-warning-fix #2314

Merged

jonagil1661 and others added 3 commits January 9, 2025 16:56

Merge branch 'ros2' into compiler-warning-fix

bb62fed

update with most current ros2 branch

fixed some unused variable warnings

8717d6e

Fix Code Style On compiler-warning-fix (#2314)

4e5bbf6

automated style fixes Co-authored-by: jonagil1661 <[email protected]>

sid-parikh requested changes Mar 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed compiler warnings #2313

Fixed compiler warnings #2313

rociopv06 commented Dec 9, 2024

sid-parikh left a comment

sid-parikh Jan 23, 2025

sid-parikh Jan 23, 2025

sid-parikh Jan 23, 2025

sid-parikh Jan 23, 2025

sid-parikh Jan 23, 2025

sid-parikh Jan 23, 2025

sid-parikh Mar 12, 2025

sid-parikh Mar 12, 2025

sid-parikh Mar 12, 2025

sid-parikh Mar 12, 2025

sid-parikh Mar 12, 2025

	if (!was_used && (int64_t) kalman_ball_list_.size() < PARAM_max_num_kalman_balls) {
	if (!was_used && static_cast<int64_t>(kalman_ball_list_.size()) < PARAM_max_num_kalman_balls) {

	if (!was_used && (int64_t) kalman_ball_list_.size() < PARAM_max_num_kalman_balls) {
	if (!was_used && static_cast<decltype(PARAM_max_num_kalman_balls)>(kalman_ball_list_.size()) < PARAM_max_num_kalman_balls) {

Fixed compiler warnings #2313

Are you sure you want to change the base?

Fixed compiler warnings #2313

Conversation

rociopv06 commented Dec 9, 2024

sid-parikh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment