Split Link Kick into 2 Planners #2242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts/robocup-software into line_kick_two_planners
sid-parikh
requested changes
Apr 10, 2024
|
also merge style checks |
automated style fixes Co-authored-by: Squid5678 <[email protected]>
Co-authored-by: Sid Parikh <[email protected]>
sanatd33
requested changes
Apr 23, 2024
| FacePoint{plan_request.motion_command.target.position}}; | ||
| modified_request.motion_command = modified_command; | ||
|
|
||
| return path_target_.plan(modified_request); | ||
| return initial_planner.plan(modified_request); |
There was a problem hiding this comment.
looks like you missed the underscore after the variable name so it isn't compiling
| } | ||
|
|
||
| void LineKickPathPlanner::process_state_transition() { | ||
| // Let PathTarget decide when the first stage is done | ||
| // Possible problem: can PathTarget get stuck and loop infinitely? | ||
| if (current_state_ == INITIAL_APPROACH && path_target_.is_done()) { | ||
| if (current_state_ == INITIAL_APPROACH && initial_planner.is_done()) { |
| @@ -45,7 +45,8 @@ class LineKickPathPlanner : public PathPlanner { | |||
|
|
|||
| State current_state_{INITIAL_APPROACH}; | |||
|
|
|||
| PathTargetPathPlanner path_target_{}; | |||
| PathTargetPathPlanner initial_planner_{}; | |||
| PathTargetPathPlanner final_planner{}; | |||
There was a problem hiding this comment.
fix case style by renaming final_planner to final_planner_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits line kick into 2 planners.
Associated / Resolved Issue
Resolves # or ClickUp card
Design Documents
Link
Steps to Test
Test Case 1
Expected result:???
Key Files to Review
Group 1
Group 2
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.