Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed on_actionResetField_triggered() method #2157

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

jvogt23
Copy link
Contributor

@jvogt23 jvogt23 commented Jan 15, 2024

Description

Describe your pull request.
Added hard-coded positions to the method in main_window.cpp that resets the field. Previous algorithm set invalid y-coordinate which prevents robots 0 and 3 from showing up on the field

Associated / Resolved Issue

Resolves # or ClickUp card
#86ayqjnmt - robot 0 and 3: learn how to configure ER-force sim

Design Documents

Link

Steps to Test

Test Case 1: Startup of simulator

  1. Step 1 Run the simulator
  2. Step 2 Observe the robots' positions

Test Case 2: Resetting from Play, Stop, and Halt

  1. Step 1 Hit Play
  2. Step 2 Reset Field
  3. Step 3 Hit Play, then Stop
  4. Step 4 Reset Field
  5. Step 5 Hit Play then Halt
  6. Step 6 Reset field

Expected result:???
In most circumstances, the robots should form a rectangle 3-wide and 2-tall in the upper center of the field, and the ball should be in the center of the field.

Key Files to Review

Group 1

  • File 1 main_window.cpp
  • File 2

Group 2

  • File 3
  • File 4

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

(Optional) Sub-issues (for drafts)

Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.

  • Step 1
  • Step 2

@jvogt23 jvogt23 requested a review from kasohrab January 15, 2024 01:33
Copy link
Contributor

@sid-parikh sid-parikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@sid-parikh sid-parikh merged commit 0b04131 into ros2 Jan 23, 2024
2 checks passed
@sid-parikh sid-parikh deleted the jamesAalind/fixReset branch January 23, 2024 17:09
sanatd33 pushed a commit that referenced this pull request Jan 29, 2024
Added hard-coded robot positions in main_window reset method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants