Speed Calculation in Sim #2153
Merged
Speed Calculation in Sim #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sid-parikh
requested changes
Jan 11, 2024
|
@sid-parikh made the changes as requested. |
automated style fixes Co-authored-by: Squid5678 <[email protected]>
sid-parikh
requested changes
Jan 23, 2024
|
quick tip: push the "re-request review" button on my name after you make changes so I'll see it again. |
sid-parikh
approved these changes
Jan 29, 2024
automated style fixes Co-authored-by: jvogt23 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
James and I (Aalind) were assigned a task to calculate the speed necessary to pass in sim. We used the Technical Description Paper from Tigers Mannheim in order to find an accurate formula to use. We also created constants that will need to be tuned. As of right now, the values are tuned for the simulator.
Associated / Resolved Issue
Resolves https://app.clickup.com/2209401/v/l/li/900501233982
Design Documents
N/A
Steps to Test
Works as expected in sim when run. Further testing needs to be done on an actual robot.
Expected result:
Passing works as expected (with speed changing based on distance).
Key Files to Review
Offense
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.