Remove Defense obstacles from coach node #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automated style fixes Co-authored-by: petergarud <[email protected]>
rishiso
reviewed
Oct 23, 2023
|
|
||
| PlayState last_play_state_ = PlayState::halt(); | ||
| FieldDimensions current_field_dimensions_; | ||
| bool have_field_dimensions_ = false; |
There was a problem hiding this comment.
this could just be bool have_field_dimensions_;
rishiso
reviewed
Oct 23, 2023
rj_gameplay/stp/pylint_stp.py
Outdated
rishiso
reviewed
Oct 23, 2023
rishiso
reviewed
Oct 23, 2023
.gitignore
Outdated
There was a problem hiding this comment.
This change is fine, but please put this in a separate PR
p-nayak11
approved these changes
Nov 8, 2023
|
Merged into #2107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed defense obstacles calculation from coach node and moved to Global State
Associated / Resolved Issue
Resolves # https://app.clickup.com/t/86ayb2pbt
Still needs to be tested
Review Checklist
(Optional) Sub-issues (for drafts)
Note: if you find yourself breaking this PR into many smaller features, it may make sense to break up the PR into logical units based on these features.