Issue 2582 #2601
Closed
Issue 2582 #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging latest master into this branch
saramsey
requested review from
bazarkua,
chunyuma,
dkoslicki and
sundareswarpullela
Member
Author
|
Before merging, we should make sure we fix #2602 so we have a baseline of "NGD API command works" before merging this code cleanup PR. |
Member
Author
|
Need to fix #2602 first and then do some testing of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code-cleanup of modules that are hopefully no longer needed, under
RTX/code/reasoningtool(especially underRTX/code/reasoningtool/kg-construction). Need some help reviewing this. See the parent issue #2582.