-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/pyo3 #1847
Merged
Merged
Update/pyo3 #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljeub-pometry
force-pushed
the
update/pyo3
branch
from
November 6, 2024 13:09
5d5b559
to
2cef835
Compare
miratepuffin
reviewed
Nov 6, 2024
miratepuffin
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - wanna add python 13 to the tests/releases?
ljeub-pometry
force-pushed
the
update/pyo3
branch
from
November 6, 2024 13:40
2cef835
to
b1a0f84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
update pyo3 to latest version
Why are the changes needed?
we are falling behind on pyo3 and there are a lot of changes happening
Does this PR introduce any user-facing change? If yes is this documented?
no
How was this patch tested?
the tests
Note this is currently waiting for a new release of kdam (pr clitic/kdam#21 is merged)