[CI] Stop relying on system BerkeleyDB packages for native builds#2970
Merged
Fuzzbawls merged 6 commits intoPIVX-Project:masterfrom Jun 30, 2025
Merged
[CI] Stop relying on system BerkeleyDB packages for native builds#2970Fuzzbawls merged 6 commits intoPIVX-Project:masterfrom
Fuzzbawls merged 6 commits intoPIVX-Project:masterfrom
Conversation
Using `brew --prefix` alone is not sufficient to determine if a homebrew package is actually installed.
Rather than overriding the paths directly, append homebrew paths within FindBerkeleyDB.cmake.
Some of the required homebrew packages are already installed on CI runners, silence warnings about the already installed packages.
Allow for a CI mode that doesn't append `db4` to the prefix path. Also update config.guess/config.sub and apply a patch for macOS Big Sur and above.
No longer rely on system packages to install BerkeleyDB. Instead, use the install_db4.sh script to compile it.
Invoking configure from within cmake on macOS results in a broken c++ compiler check using system clang++. Work around this by running configure first outside of cmake.
Duddino
approved these changes
May 16, 2025
Liquid369
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependence on system package managers to provide the BerkeleyDB library for native build jobs. Instead, use the supplied
install_db4.shscript to compile and install BerkeleyDB into a system path (/usr/local).Rationale for this change is that Homebrew is going to remove BerkeleyDB 4 from it's package manager soon, so this is a proactive change to prevent CI build jobs from breaking when that happens.
Homebrew based BerkeleyDB 4 support is still retained on our end for those that already have the package installed.
Linux native CI build jobs are also switched over to this method of compiling/installing BerkeleyDB 4, rather than using the package manager's BerkeleyDB 5.