fix: Allow vAlign and vMerge on Style\Cell to be set to null #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
SpraxDev
changed the title
4 tasks
…ce#2673) vAlign and vMerge are initialized as `null` in every style until it is explicitly set. Right now, it is not possible to unset them, after it has been set once. I've added a null-check to skip the validation, based on the default parameter value of `null`, which indicates to me that it once was intended to work like this. I've also fixed the type-hints, which were wrong from the start.
SpraxDev
force-pushed
the
fix/allow-unsetting-cell-style-vmerge-valign
branch
from
6ca43db to
116be46
Compare
|
Thanks @Progi1984! I've pushed the test changes |
This should fix the reduction in test coverage because of the new null checking code in the Setter
Progi1984
approved these changes
Sep 13, 2024
|
@SpraxDev Thanks again for your contribution 🤟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
vAlign and vMerge are initialized as
nulluntil it is explicitly set. Right now, it is not possible to unset them, after it has been set once.I've added a null-check to skip the validation, based on the default parameter value of
null, which indicates to me that it once was intended to work like this.I've also fixed the type-hints, which were wrong from the start.
Fixes #2673
Checklist:
I have updated the documentation to describe the changes(does not apply)