Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test case for vMerge's default value of continue #2677

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

SpraxDev
Copy link
Contributor

@SpraxDev SpraxDev commented Sep 13, 2024

Description

This new test case essentially covers the changes in b457ff5.
It ensures the new behavior works as intended and doesn't break/change by accident in the future.

Fixes # (issue) (does not apply)

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes (does not apply)
  • I have updated the changelog (does not apply)

@SpraxDev

This comment was marked as outdated.

@coveralls
Copy link

coveralls commented Sep 13, 2024

Coverage Status

coverage: 96.918%. remained the same
when pulling 05d8170 on SpraxDev:test/vmerge-parsed-default-value
into f0ec497 on PHPOffice:master.

This new test case essentially covers the changes in b457ff5.
It ensures the new behavior works as intended and
doesn't break/change by accident in the future.
@SpraxDev SpraxDev force-pushed the test/vmerge-parsed-default-value branch from 6788e80 to 19ae1c7 Compare September 13, 2024 14:21
@Progi1984
Copy link
Member

@SpraxDev Could you update the changelog, please ?

@SpraxDev
Copy link
Contributor Author

@SpraxDev Could you update the changelog, please ?

Sure – I've added it under Miscellaneous

@Progi1984 Progi1984 merged commit 43785fe into PHPOffice:master Sep 13, 2024
12 checks passed
@Progi1984
Copy link
Member

@SpraxDev Perfect job. Thank you.

@SpraxDev SpraxDev deleted the test/vmerge-parsed-default-value branch September 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants