Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for vAlign styles in the HTML Writer (Table) #2675

Merged

Conversation

SpraxDev
Copy link
Contributor

@SpraxDev SpraxDev commented Sep 13, 2024

Description

vAlign is parsed by PHPWord but the HTMLWriter does not support it yet.

Fixes # (issue) (no related open issue found)

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes (does not apply)
  • I have updated the changelog

@SpraxDev SpraxDev force-pushed the feat/support-valign-styles-in-html-writer branch from 9a127a4 to 70b6536 Compare September 13, 2024 08:46
@coveralls
Copy link

coveralls commented Sep 13, 2024

Coverage Status

coverage: 96.916%. remained the same
when pulling 70b6536 on SpraxDev:feat/support-valign-styles-in-html-writer
into 2e4f3cf on PHPOffice:master.

@SpraxDev SpraxDev marked this pull request as ready for review September 13, 2024 09:04
Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@Progi1984 Progi1984 merged commit fa0cea0 into PHPOffice:master Sep 13, 2024
13 checks passed
@Progi1984
Copy link
Member

@SpraxDev Thank you for your contribution

@SpraxDev SpraxDev deleted the feat/support-valign-styles-in-html-writer branch September 13, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants