-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to jsonschema 4.18.0 #123
Conversation
Test failure is from BODS being included, again. |
jsonschema will continue to release new versions, so it makes sense to keep up with its development. Also, this prevents a scenario where you’ll be tempted to set a maximum version on jsonschema when some future version causes an error. |
Changes are quite small when you ignore whitespace: https://github.com/OpenDataServices/lib-cove/pull/123/files?w=1 The main change is the minimum version. |
This PR removes
That is on main but is not released yet - replaces it with specifying a "registry" value instead. Is this ok? |
I would like I don't think this PR removes |
@odscjames I fixed the merge conflicts, in case that helps. |
@odscjames I've added a new block to cove-oc4ids to display additional_closed_codelist_values and I have a branch ready for lib-cove-oc4ids where tests pass under the new version of lib-cove. So, please don't let oc4ids or ocds integration tests be a blocker – I'll take responsibility for those. |
This PR's diff is easier to read with whitespace ignored: https://github.com/OpenDataServices/lib-cove/pull/123/files?w=1 |
Done in #142 |
Closes #112
Closes #130
As described in the documentation linked from #112 , the new version of jsonschema separates resolution from caching.
RefResolver had no
handlers
by default. lib-cove had copied these lines.This also fixes
add_is_codelist()
being unreachable from one branch of the if-statement, a bug introduced in 011a2bdThe upgraded causes
test_property_that_is_not_json_schema_doesnt_raise_exception
to now raises an error. I'm not sure why this scenario shouldn't raise an error.jsonschema 4.18 drops support for Python 3.6 and 3.7.
Includes #118