-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 0.31.0 (@jpmckinney's changes) #122
Conversation
#84 Original pull request: #115 Ben has edited the changelog only. Co-authored-by: James McKinney <[email protected]> Co-authored-by: Ben Webb <[email protected]>
#28 Original pull request: #116 Ben has edited the changelog only. Co-authored-by: James McKinney <[email protected]> Co-authored-by: Ben Webb <[email protected]>
#118 Ben has edited the changelog only. Co-authored-by: James McKinney <[email protected]> Co-authored-by: Ben Webb <[email protected]>
#120 Ben has edited the changelog only. Co-authored-by: James McKinney <[email protected]> Co-authored-by: Ben Webb <[email protected]>
(as main has changes that cove-ocds isn't compatible with yet)
Could #121 be included? Any environment with flattentool already installed won’t see a change. Also I think the OCDS integration should pass now. Locking to a specific version makes the integration test a little less useful. Edit: or, I can update the integration once I’m done making changes. |
Ah, I see you're cloning lib-cove-ocds. If you pip install it, then you'll always get a version that works with cove-ocds, because cove-ocds only uses released versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure the jsonschema validator changes are backwards compatible with earlier versions of that library?
(I'll leave Q about #121 to Ben; I don't know if it's better to get this out today and look at that later, I suspect there might be some cans of worms there so that seems good to me) |
I've tested this with older jsonschema, and it seems to work fine. #121 is not included, but I will look at that next. |
I've released this on PyPI. |
Thank you! |
No description provided.