Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 0.31.0 (@jpmckinney's changes) #122

Merged
merged 8 commits into from
Jul 7, 2023
Merged

release: 0.31.0 (@jpmckinney's changes) #122

merged 8 commits into from
Jul 7, 2023

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented Jul 6, 2023

No description provided.

jpmckinney and others added 8 commits July 6, 2023 15:16
#84

Original pull request:
#115

Ben has edited the changelog only.

Co-authored-by: James McKinney <[email protected]>
Co-authored-by: Ben Webb <[email protected]>
#28

Original pull request:
#116

Ben has edited the changelog only.

Co-authored-by: James McKinney <[email protected]>
Co-authored-by: Ben Webb <[email protected]>
#118

Ben has edited the changelog only.

Co-authored-by: James McKinney <[email protected]>
Co-authored-by: Ben Webb <[email protected]>
#120

Ben has edited the changelog only.

Co-authored-by: James McKinney <[email protected]>
Co-authored-by: Ben Webb <[email protected]>
(as main has changes that cove-ocds isn't compatible with yet)
@Bjwebb Bjwebb requested a review from odscjames July 6, 2023 15:20
@jpmckinney
Copy link
Contributor

jpmckinney commented Jul 6, 2023

Could #121 be included? Any environment with flattentool already installed won’t see a change.

Also I think the OCDS integration should pass now. Locking to a specific version makes the integration test a little less useful.

Edit: or, I can update the integration once I’m done making changes.

@jpmckinney
Copy link
Contributor

Ah, I see you're cloning lib-cove-ocds. If you pip install it, then you'll always get a version that works with cove-ocds, because cove-ocds only uses released versions.

Copy link
Collaborator

@odscjames odscjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure the jsonschema validator changes are backwards compatible with earlier versions of that library?

@odscjames
Copy link
Collaborator

(I'll leave Q about #121 to Ben; I don't know if it's better to get this out today and look at that later, I suspect there might be some cans of worms there so that seems good to me)

@Bjwebb
Copy link
Member Author

Bjwebb commented Jul 7, 2023

I've tested this with older jsonschema, and it seems to work fine.

#121 is not included, but I will look at that next.

@Bjwebb Bjwebb merged commit a97f769 into main Jul 7, 2023
@Bjwebb
Copy link
Member Author

Bjwebb commented Jul 7, 2023

I've released this on PyPI.

@jpmckinney
Copy link
Contributor

Thank you!

@jpmckinney
Copy link
Contributor

In terms of OCP's needs, #123 is higher priority than #121.

Besides jsonschema compatibility, #123 allows lib-cove-ocds to control $ref resolution. There are other ways of satisfying the latter. This is getting in the way of some improvements (unless we start publishing releases of the fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants